Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIMPLE-FORMS] fix: update upload page content to be more accessible #34416

Merged
merged 2 commits into from
Jan 31, 2025
Merged

[SIMPLE-FORMS] fix: update upload page content to be more accessible #34416

merged 2 commits into from
Jan 31, 2025

Conversation

pennja
Copy link
Contributor

@pennja pennja commented Jan 30, 2025 •
edited
Loading

Summary

  • This work updates the form upload page to be more accessible by wrapping the form page in a fieldset and giving the title/description a legend.
  • I work for the Veteran Facing Forms team who owns and maintains this component

Related issue(s)

Testing done

  • Browser testing successful

Requested Feedback

Any

@pennja pennja requested review from a team as code owners January 30, 2025 22:23
rhasselle-oddball
rhasselle-oddball approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@rhasselle-oddball rhasselle-oddball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! 🚀

@pennja pennja merged commit f1263de into main Jan 31, 2025
79 checks passed
@pennja pennja deleted the jap/simple-forms/101265-b branch January 31, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhasselle-oddball rhasselle-oddball rhasselle-oddball approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pennja @rhasselle-oddball @va-vfs-bot @Japenner