Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging Review finding: Important instructions may be missed by screen reader users #101265

Open
3 tasks
shiragoodman opened this issue Jan 16, 2025 · 1 comment
Open
3 tasks
Assignees
Labels
1-forms-audit-digitize Veteran Facing Forms Team a11y-defect-2 High-severity accessibility issue that should be fixed in the next 1 - 2 sprints accessibility CC-Dashboard To be included in Collab Cycle Dashboard collab-cycle-feedback For VSP Collaboration cycle feedback assigned to VFS Comprehension document-upload exp-std-task-completion modality-screen-reader Staging

Comments

@shiragoodman
Copy link
Contributor

shiragoodman commented Jan 16, 2025

Need help? Please review how to read a Staging Review ticket. Tag @platform-governance-team-members on Slack if you need further assistance.

Product Information

Team: Veteran Facing Forms
Product: Direct Upload
Feature: Document Upload

Findings details

VA.gov Experience Standard - issue: User has enough information to complete a task.
VA.gov Experience Standard - category: Comprehension
Launch-blocking: No
Design System review: No
Collab Cycle Reviewer: @briandeconinck (Accessibility)

Description

On /upload, there's a paragraph that reads:

Note: After you upload your file, you’ll need to continue to the next screen to submit it. If you leave before you submit it, you’ll need to upload it again.

This text isn't programmatically associated with the file input, so a screen reader user who tabs straight to the input isn't likely to hear it. Since this is behavior that diverges from the norm for VA.gov forms (and contradicts the "we'll save your changes" message elsewhere in the form flow), it's important that screen reader users are aware of it.

Link, screenshot or steps to recreate

Upload input preceded by paragraph reading "Note: After you upload your file, you’ll need to continue to the next screen to submit it. If you leave before you submit it, you’ll need to upload it again."

Recommended action

I think this is a pretty easy fix --- wrap the whole thing in a fieldset and place the "Your file" heading and the "Note" text in a legend for the fieldset, as you've done elsewhere in the form flow.

References

  • Accessibility Defect Severity: 2: High. Should be fixed in 1-2 sprints post-launch.
  • WCAG Success Criteria: N/A
  • Modality: Screen reader
  • Design System Component: N/A
  • Design System Pattern or Template: N/A
  • Design System Foundation: N/A
  • Content Style Guide: N/A
  • Context: N/A

Next Steps for the VFS Team

How did this touchpoint go? Give feedback on the Collaboration Cycle at any time.

  • Questions? For the most timely response, comment on Slack in your team channel tagging @platform-governance-team-members with any questions or to get help validating the issue.
  • Ticket ownership: If you believe that this issue is out of scope, not your team's responsibility, or a Design System issue, comment and tag @platform-governance-team-members on your team channel in Slack to provide an explanation and who you believe is responsible. The Governance team will follow up.
  • Close this ticket when the issue has been resolved or validated by your Product Owner.
@jeana-adhoc
Copy link
Contributor

jeana-adhoc commented Jan 29, 2025

@pennja -

We need to look at this a little differently. The fieldset needs to wrap all the way around the va-file-input component as well.

Currently the code is like this...

<fieldset>
  <legend> 
    h3... 
    description text 
  </legend>
</fieldset>

<va-file-input>

And it should be like this...

<fieldset>

  <legend> 
    h3... 
    description text 
  </legend>

  <va-file-input>

</fieldset>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-forms-audit-digitize Veteran Facing Forms Team a11y-defect-2 High-severity accessibility issue that should be fixed in the next 1 - 2 sprints accessibility CC-Dashboard To be included in Collab Cycle Dashboard collab-cycle-feedback For VSP Collaboration cycle feedback assigned to VFS Comprehension document-upload exp-std-task-completion modality-screen-reader Staging
Projects
None yet
Development

No branches or pull requests

5 participants