Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Gemfile.lock #15700

Merged
merged 3 commits into from
Feb 27, 2024
Merged

Fix Gemfile.lock #15700

merged 3 commits into from
Feb 27, 2024

Conversation

holdenhinkle
Copy link
Contributor

@holdenhinkle holdenhinkle commented Feb 27, 2024

Fix Gemfile.lock

Summary

This PR reverts some changes that were made to Gemfile.lock when I created a new Rails module in this PR.

I manually updated the file by running these commands:

bundle lock --add-platform ruby
bundle lock --remove-platform x86_64-darwin-22

Related issue(s)

  • Link to ticket created in va.gov-team repo OR screenshot of Jira ticket if your team uses Jira
  • Link to previous change of the code/bug (if applicable)
  • Link to epic if not included in ticket

Testing done

  • New code is covered by unit tests
  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature?

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@holdenhinkle holdenhinkle enabled auto-merge (squash) February 27, 2024 21:01
@holdenhinkle holdenhinkle merged commit 7198873 into master Feb 27, 2024
18 checks passed
@holdenhinkle holdenhinkle deleted the hh-fix-gemfilelock branch February 27, 2024 22:40
rjohnson2011 added a commit that referenced this pull request Feb 27, 2024
* Resolve bundle-audit error (#15704)

* Change rack-cors version to fix bundle-audit error

* Add ignore flag to bundle audit

* Restore rack cors version 2.0.1

* Update bundle-audit

* Fix Gemfile.lock (#15700)

* remove x86_64-darwin-22 using bundle lock --remove-platform command

* add ruby using bundle lock --add-platform command

* Remove code-checks.yml

---------

Co-authored-by: Holden Hinkle <[email protected]>
rjohnson2011 added a commit that referenced this pull request Feb 28, 2024
* Resolve bundle-audit error (#15704)

* Change rack-cors version to fix bundle-audit error

* Add ignore flag to bundle audit

* Restore rack cors version 2.0.1

* Update bundle-audit

* Fix Gemfile.lock (#15700)

* remove x86_64-darwin-22 using bundle lock --remove-platform command

* add ruby using bundle lock --add-platform command

* Dbex user identifiers status check (#14858)

* Include Form526 user identifier presence mapping in user profile

Includes the mapping of required Form526 user identifier data generated by the Users::Form526UserIdentifiersStatusService in the user profile returned from the main user endpoint.

The front end will use this information to display to the user any identifiers we don't have in our system, so they can pass that information on to the Contact Center.

Adds a feature flag, form_526_required_identifiers_in_user_object, and gates the presence of this data in the profile.

* Update User LOA JSON Schema validations for 526 identifiers

Updates four JSON schema validation files to relfect the addition of the form526_required_identifier_presence key to the users profile metadata

* Add user arg to feature flags

Forgot to pass the user arg to this feature flag. We want to allow this level of control so we could release this change progressively if we wanted to

* Satisfy outstanding Rubocop warning to use anonymous positional arguments forwarding

* Fix Flipper disable in profile test

The user argument doesn't seem to work properly when enabling and disabling Flippers in specs. Confident this is working properly in the actual codebase though.

* Address style suggestion in metadata conditional

Prefer unless statement and early return to if statment in this case

---------

Co-authored-by: Eric Boehs <[email protected]>

* Adds count of records written to log message (#15705)

* Use LOA2 instead of LOA3 for datebox timestamp logic (#15655)

* revert(vaos): removed clinic stop code logging (#15693)


va.gov-team#71272

* Filter Unwanted Errors from Retrying (Dependents Forms) (#15545)

* Add filters from exception cause

* Use sidekiq skip mechanism

* Use common method to submit backup

* Move filter handling to method

* Params for filter method

* Lint issues

* Fix icn as instance var

* Missed 686c param

* Move salvage form to top of rescue block

* Same for other job

* Remove code checks

* updated cve file in build workflow

---------

Co-authored-by: Holden Hinkle <[email protected]>
Co-authored-by: Nathan Burgess <[email protected]>
Co-authored-by: Eric Boehs <[email protected]>
Co-authored-by: gia-lexa <[email protected]>
Co-authored-by: Eric Tillberg <[email protected]>
Co-authored-by: AJ Magdub <[email protected]>
Co-authored-by: Tyler Fink <[email protected]>
Co-authored-by: RachalCassity <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
find-a-representative Benefits Representation Management product label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants