VAOS Removed Clinics Stop Code Logging #15693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
71272-vaos-remove-clinic-stop-code-logging/main/main
va-vfs-bot
temporarily deployed
to
71272-vaos-remove-clinic-stop-code-logging/main/main
va-vfs-bot
temporarily deployed
to
71272-vaos-remove-clinic-stop-code-logging/main/main
rjohnson2011
added a commit
that referenced
this pull request
Feb 28, 2024
* Resolve bundle-audit error (#15704) * Change rack-cors version to fix bundle-audit error * Add ignore flag to bundle audit * Restore rack cors version 2.0.1 * Update bundle-audit * Fix Gemfile.lock (#15700) * remove x86_64-darwin-22 using bundle lock --remove-platform command * add ruby using bundle lock --add-platform command * Dbex user identifiers status check (#14858) * Include Form526 user identifier presence mapping in user profile Includes the mapping of required Form526 user identifier data generated by the Users::Form526UserIdentifiersStatusService in the user profile returned from the main user endpoint. The front end will use this information to display to the user any identifiers we don't have in our system, so they can pass that information on to the Contact Center. Adds a feature flag, form_526_required_identifiers_in_user_object, and gates the presence of this data in the profile. * Update User LOA JSON Schema validations for 526 identifiers Updates four JSON schema validation files to relfect the addition of the form526_required_identifier_presence key to the users profile metadata * Add user arg to feature flags Forgot to pass the user arg to this feature flag. We want to allow this level of control so we could release this change progressively if we wanted to * Satisfy outstanding Rubocop warning to use anonymous positional arguments forwarding * Fix Flipper disable in profile test The user argument doesn't seem to work properly when enabling and disabling Flippers in specs. Confident this is working properly in the actual codebase though. * Address style suggestion in metadata conditional Prefer unless statement and early return to if statment in this case --------- Co-authored-by: Eric Boehs <[email protected]> * Adds count of records written to log message (#15705) * Use LOA2 instead of LOA3 for datebox timestamp logic (#15655) * revert(vaos): removed clinic stop code logging (#15693) va.gov-team#71272 * Filter Unwanted Errors from Retrying (Dependents Forms) (#15545) * Add filters from exception cause * Use sidekiq skip mechanism * Use common method to submit backup * Move filter handling to method * Params for filter method * Lint issues * Fix icn as instance var * Missed 686c param * Move salvage form to top of rescue block * Same for other job * Remove code checks * updated cve file in build workflow --------- Co-authored-by: Holden Hinkle <[email protected]> Co-authored-by: Nathan Burgess <[email protected]> Co-authored-by: Eric Boehs <[email protected]> Co-authored-by: gia-lexa <[email protected]> Co-authored-by: Eric Tillberg <[email protected]> Co-authored-by: AJ Magdub <[email protected]> Co-authored-by: Tyler Fink <[email protected]> Co-authored-by: RachalCassity <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Clinic stop code logging is no longer required. Removed clinic stop code logging methods, VAOS::V2::ClinicsController#log_clinic_info and VAOS::V2::ClinicsController#get_clinic_info.
Related issue(s)
department-of-veterans-affairs/va.gov-team#71272
Testing done
Removed tests covering clinic stop code logging.