React #746
Closed
React #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You need to allow webpack-dev-server host as allowed origin for connect-src. This can be done in Rails 5.2+ for development environment in the CSP initializer config/initializers/content_security_policy.rb with a snippet like this: policy.connect_src :self, :https, "http://localhost:3035", "ws://localhost:3035" if Rails.env.development?
…bct-data-service into react
…bct-data-service into react
3) UploadsController behaves like an authenticating controller when being visited and submitting credentials outputs an error message if not successful
Failure/Error: visit user_session_path
Capybara::Poltergeist::JavascriptError:
One or more errors were raised in the Javascript code on the page. If you don't care about these errors, you can ignore them by setting js_errors: false in your Poltergeist configuration (see documentation for details).
ReferenceError: Can't find variable: Set
ReferenceError: Can't find variable: Set
at http://127.0.0.1:58010/packs-test/js/application-8ab2d686105b554977a1.js:35163
at http://127.0.0.1:58010/packs-test/js/application-8ab2d686105b554977a1.js:35498 in ./node_modules/scheduler/cjs/scheduler-tracing.development.js
at http://127.0.0.1:58010/packs-test/js/application-8ab2d686105b554977a1.js:20 in __webpack_require__
at http://127.0.0.1:58010/packs-test/js/application-8ab2d686105b554977a1.js:36574 in ./node_modules/scheduler/tracing.js
at http://127.0.0.1:58010/packs-test/js/application-8ab2d686105b554977a1.js:20 in __webpack_require__
at http://127.0.0.1:58010/packs-test/js/application-8ab2d686105b554977a1.js:4581
at http://127.0.0.1:58010/packs-test/js/application-8ab2d686105b554977a1.js:32258 in ./node_modules/react-dom/cjs/react-dom.development.js
at http://127.0.0.1:58010/packs-test/js/application-8ab2d686105b554977a1.js:20 in __webpack_require__
at http://127.0.0.1:58010/packs-test/js/application-8ab2d686105b554977a1.js:32301 in ./node_modules/react-dom/index.js
at http://127.0.0.1:58010/packs-test/js/application-8ab2d686105b554977a1.js:20 in __webpack_require__
at http://127.0.0.1:58010/packs-test/js/application-8ab2d686105b554977a1.js:34627 in ./node_modules/react_ujs/react_ujs/index.js
at http://127.0.0.1:58010/packs-test/js/application-8ab2d686105b554977a1.js:20 in __webpack_require__
at http://127.0.0.1:58010/packs-test/js/application-8ab2d686105b554977a1.js:118 in ./app/javascript/packs/application.js
at http://127.0.0.1:58010/packs-test/js/application-8ab2d686105b554977a1.js:20 in __webpack_require__
at http://127.0.0.1:58010/packs-test/js/application-8ab2d686105b554977a1.js:84
Shared Example Group: "an authenticating controller" called from ./spec/controllers/uploads_controller_spec.rb:9
# ./spec/controllers/shared_examples/shared_examples_for_authentication.rb:30:in `block (4 levels) in <top (required)>'
…bct-data-service into react
This reverts commit e32324d.
…bct-data-service into react
…bct-data-service into react
…bct-data-service into react
…bct-data-service into react
…bct-data-service into react
…bct-data-service into react
…bct-data-service into react
…bct-data-service into react
…bct-data-service into react
…bct-data-service into react
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
department-of-veterans-affairs/va.gov-team#14964
Adding React by following instructions at https://github.com/reactjs/react-rails#rails-5x
Applied fix was rails/webpacker#522 (comment) which created
bin/yarnSet CODEOWNERS for React directories and files to @department-of-veterans-affairs/bah-gibct
Testing done
Screenshots
Acceptance criteria
Definition of done