Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CT: Add React to GIDS #14964

Closed
dneel-bah opened this issue Oct 16, 2020 · 3 comments
Closed

CT: Add React to GIDS #14964

dneel-bah opened this issue Oct 16, 2020 · 3 comments

Comments

@dneel-bah
Copy link
Contributor

dneel-bah commented Oct 16, 2020

A a developer I need to add the React library to GIDS so that it has the ability to use the same tech stack as the Comparison Tool.

Assumptions:

  1. This work is to only add the library, and will not be an entire refactor.
  2. Codeowner for this directory is our team so that back-end does not have to review react changes.

Acceptance Criteria:

  1. The React library is included as part of the GIDS project.
  2. Smoke testing passes

PRs

Recommend using new PRs, but these can be used for reference:
Main PR

Supporting Artifacts:

  1. https://github.com/reactjs/react-rails#rails-5x
  2. Initial work was done in this story, but never merged in: https://github.com/department-of-veterans-affairs/vets.gov-team/issues/19826
@jhouse-solvd
Copy link
Contributor

Spoke w/ @desireeturner and she indicated that they would like to get this resolved within the next 2 weeks if possible ie during this Sprint.

@desireeturner
Copy link
Contributor

This is being discussed on slack here: https://dsva.slack.com/archives/CG6N59X40/p1604433713032900

@dneel-bah
Copy link
Contributor Author

Closing as OBE. The original work was done, but it took a while to approve so the work/pull requests will have to be redone. Will create a new story when the team is ready to tackle this work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants