Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ale_linters: python: ruff): add --stdin-filename if version >= 0.0.69 #4414

Merged
merged 1 commit into from
Jan 27, 2023
Merged

fix(ale_linters: python: ruff): add --stdin-filename if version >= 0.0.69 #4414

merged 1 commit into from
Jan 27, 2023

Conversation

actionless
Copy link
Contributor

@actionless actionless commented Jan 7, 2023 •
edited
Loading

Where are the tests? Have you added tests? Have you updated the tests? Read the
comment above and the documentation referenced in it first. Write tests!

Seriously, read :help ale-dev and write tests.

yes

@actionless actionless changed the title fix(ale_linters: python: ruff): add --stdin-filename if version > 0.0.69 fix(ale_linters: python: ruff): add --stdin-filename if version >= 0.0.69 Jan 7, 2023
@actionless actionless force-pushed the ruff-stdin-filename branch 3 times, most recently from 9528132 to 8f617a0 Compare January 7, 2023 01:03
@actionless actionless force-pushed the ruff-stdin-filename branch from 8f617a0 to bdd3f8c Compare January 7, 2023 01:10
@yining
Copy link
Contributor

yining commented Jan 7, 2023

Good catch, thanks for the fix. I forgot to add '--stdin-filename' to linter after adding that to fixer.

This was referenced Jan 12, 2023
Closed
Closed
hsanson
hsanson approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@hsanson hsanson merged commit 26c7901 into dense-analysis:master Jan 27, 2023
@StevenMaude StevenMaude mentioned this pull request Sep 6, 2023
Open
spladug pushed a commit to spladug/ale that referenced this pull request Oct 24, 2023
@actionless @spladug
fix(ale_linters: python: ruff): add --stdin-filename if version > 0.0…
25458a5 
….69 (dense-analysis#4414)
mnikulin pushed a commit to mnikulin/ale that referenced this pull request Nov 12, 2023
@actionless @mnikulin
fix(ale_linters: python: ruff): add --stdin-filename if version > 0.0…
d1be9be 
….69 (dense-analysis#4414)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsanson hsanson hsanson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@actionless @yining @hsanson