Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruff with Ale in Nvim Shows errors on things that should be ignored #1829

Closed
colin99d opened this issue Jan 12, 2023 · 5 comments
Closed

Ruff with Ale in Nvim Shows errors on things that should be ignored #1829

colin99d opened this issue Jan 12, 2023 · 5 comments

Comments

@colin99d
Copy link
Contributor

Not sure if this is an issue here or with Ale. From the output of ruff ., you can see that S101 is being ignored. However, in the file itself I still see the warning.
Screenshot 2023-01-12 at 1 48 08 PM

@colin99d
Copy link
Contributor Author

And here is the config:

let g:ale_linters = { "python": ["ruff", "pylint"], "rust": ["analyzer"] }
let g:ale_fixers = {
\       "*": ["remove_trailing_lines", "trim_whitespace"],
\       "python": ["black", "ruff"],
\       "rust": ["rustfmt"],
\}

Also, we should probbably put instructions for this in the README, since this seems a lot easier than the suggested way of using ruff in vim.

@charliermarsh
Copy link
Member

Not super familiar with this tool... My best guess is that it's not passing the filename to Ruff? So we can't find the config?

@john-kurkowski
Copy link

My best guess is that it's not passing the filename to Ruff?

Exactly. dense-analysis/ale#4414

@colin99d
Copy link
Contributor Author

This is definitely the issue! Thanks! Charlie, should I replace our current README with Ale since the config is WAY easier? It also one of the most popular vim tools.

@charliermarsh
Copy link
Member

Gonna close since I think this is handled by the upstream issue.

@colin99d - Can you add a section for it similar to what we have for efm and null-ls?

@colin99d colin99d mentioned this issue Jan 14, 2023
charliermarsh pushed a commit that referenced this issue Jan 14, 2023
Fixes the sub issue I brought up in #1829.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants