Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.6.0 fails to disable built-in TypeScript intellisense #439

Closed
voltrevo opened this issue Jun 8, 2021 · 4 comments · Fixed by #440
Closed

3.6.0 fails to disable built-in TypeScript intellisense #439

voltrevo opened this issue Jun 8, 2021 · 4 comments · Fixed by #440
Labels
bug Something isn't working

Comments

@voltrevo
Copy link

voltrevo commented Jun 8, 2021

Describe the bug

Getting intellisense from both Deno and built-in TypeScript support, e.g.:

Screen Shot 2021-06-08 at 10 43 16 am

Downgrading to 3.5.1 resolves the issue.

To Reproduce

Blank project:

.vscode/settings.json:
  {
    "deno.enable": true,
    "deno.lint": true,
    "deno.unstable": false,
    "editor.formatOnSave": true,
    "editor.defaultFormatter": "denoland.vscode-deno"
  }

hello.ts
  Deno.readFile;

Expected behavior

No red underline under Deno, intellisense from deno extension only and not built-in TypeScript.

Screenshots

See above.

Versions

vscode: 1.56.2 deno: 1.10.3 extension: 3.6.0

@kitsonk kitsonk added the bug Something isn't working label Jun 8, 2021
@kitsonk
Copy link
Contributor

kitsonk commented Jun 8, 2021

Grrrr... I can replicate. Sorry, working on a fix now.

@kitsonk
Copy link
Contributor

kitsonk commented Jun 8, 2021

Info 34 [10:51:20.947] Couldn't find typescript-deno-plugin

Something has gone wrong with the plugin that mutes those messages... Grr....

@kitsonk
Copy link
Contributor

kitsonk commented Jun 8, 2021

It was a breaking change in a minor release of the packaging tool for Visual Studio Code: microsoft/vscode-vsce#576. Trying to figure out how to fix it now.

@matklad
Copy link

matklad commented Jun 8, 2021

Trying to figure out how to fix it now.

I often dream about npm-ecosystem-less way of developing extensions for VS Code. At it's core, an extension is just an archive with some JavaScript, and it'd be cool to "just" use deno batteries-included tools to cook it, rather than relying on the ever-improving npm tooling. But this doesn't look like the most high-priority yak to shave :D

LumaKernel added a commit to LumaKernel/coc-denoland that referenced this issue Aug 7, 2021
* feat: code lens for references (denoland#308)

* feat: disable most of builtin language service when deno enabled (denoland#307)

* 0.0.8

* feat: add applyCodeActionCommand command (denoland#312)

* fix: remove deno/applyCodeActionCommand (denoland#315)

* New high-res logo (denoland#274)

* feat: add implementations code lens configuration option (denoland#319)

* feat: add initialize workspace command (denoland#316)

* feat: support deno cache quick fix (denoland#322)

* chore: add screenshot to README (denoland#323)

* 0.0.9

* 0.0.10

* fix: typo in init command (denoland#327)

* feat: add a welcome screen for extension (denoland#329)

* feat: use preview instead of display for status (denoland#330)

* chore: README improvements (denoland#331)

* Release 3.0.0, canary is now main (denoland#332)

* 3.0.1

* Fix typo (denoland#337)

Grammar + context

* chore: activate extension on command (denoland#336)

* docs: recommend import_map.json instead of import-map.json (denoland#340)

Resolves denoland#338

* chore: move Releases.md to CHANGELOG.md for better marketplace integration (denoland#344)

Closes denoland#342

* feat: add deno.path setting (denoland#350)

* 3.1.0

* feat: read-add debug support (denoland#351)

Co-authored-by: CGQAQ <[email protected]>

* feat: add settings to affect completions (denoland#368)

* fix: manual `deno` command resolution on windows. (denoland#367)

Fixes denoland#361

* 3.2.0

* feat: support for relative path resolution (using workspaces) in deno.path (denoland#381)

Co-authored-by: Kitson Kelly <[email protected]>

* feat: add version notification message (denoland#383)

* feat: add restart language server command (denoland#385)

Resolves denoland#372

* feat: add support for import registry completions (denoland#380)

* 3.3.0

* typo in ImportCompletions.md (denoland#390)

* fix: activate on reloadImportRegistries command (denoland#407)

Fixes: denoland#394

* feat: handle per resource configuration (denoland#411)

Requires Deno with denoland/deno#10488.

Ref: denoland#348 
Resolves: denoland#314
Resolves: denoland#297

* feat: add internalDebug config flag (denoland#406)

Also integrate upstream formatting changes in deno fmt.

Ref: denoland/deno#10368

* 3.4.0

* feat: recognise json(c) & markdown files (denoland#404)

* 3.5.0

* docs: fix broken link in README (denoland#426)

* feat: support registry auto discovery (denoland#427)

* fix: bump semver of extension (denoland#429)

* 3.5.1

* feat: add support for tasks and test code lens (denoland#436)

* 3.6.0

* fix: update packaging and pin vsce version (denoland#440)

Fixes denoland#439

* 3.6.1

* feat: add support for import map in test code lens (denoland#446)

* fix: activate extension on markdown / json / jsonc (denoland#447)

* fix: setting then clearing "deno.path" config should not use empty string for path (denoland#452)

* fix: better handling when language server fails to start (denoland#454)

* 3.7.0

* fix: remove trailing slash in example (denoland#471)

* chore: remove test header from bug report issue template (denoland#479)

* feat: add ability to set cache directory in settings (denoland#477)

Closes denoland#287

* fix: properly handle plugin configuration at startup (denoland#474)

Fixes denoland#473

Co-authored-by: Kitson Kelly <[email protected]>
Co-authored-by: Luca Casonato <[email protected]>
Co-authored-by: Kirill Reunov <[email protected]>
Co-authored-by: Liam Murphy <[email protected]>
Co-authored-by: Ryan Dahl <[email protected]>
Co-authored-by: Jesse Jackson <[email protected]>
Co-authored-by: CGQAQ <[email protected]>
Co-authored-by: David Sherret <[email protected]>
Co-authored-by: Hector Menendez <[email protected]>
Co-authored-by: Heyward Fann <[email protected]>
Co-authored-by: Satya Rohith <[email protected]>
Co-authored-by: yaegassy <[email protected]>
Co-authored-by: Cedric Vangout <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants