Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible to configure DENO_DIR in WS settings #287

Closed
Tzahile opened this issue Dec 19, 2020 · 2 comments · Fixed by #477
Closed

Make it possible to configure DENO_DIR in WS settings #287

Tzahile opened this issue Dec 19, 2020 · 2 comments · Fixed by #477
Assignees
@kitsonk
Labels
enhancement New feature or request

Comments

@Tzahile
Copy link

Tzahile commented Dec 19, 2020

Is your feature request related to a problem? Please describe.

I made a Workspace for a project of mine written with Deno.
For the sake of convenience I set DENO_DIR to be the project directory.
Every time I enter my workspace, I need to configure DENO_DIR. Until then, many things don't work and the Deno extension misbehaves.

Describe the solution you'd like

Would be great if DENO_DIR setting can be configures in the workspace settings, just like the unstable option
@kitsonk kitsonk added the enhancement New feature or request label Dec 19, 2020
@kitsonk
Copy link
Contributor

kitsonk commented Dec 19, 2020

Yeah. This is a good idea. We will look to add it.

@kitsonk kitsonk mentioned this issue Jul 22, 2021
Closed
23 tasks
@kitsonk kitsonk self-assigned this Jul 26, 2021
This was referenced Jul 27, 2021
Merged
Merged
@tehbeard
Copy link

Documenting this here, as it was a workaround I came up with before #477 is implemented and merged.

I tried using a batch file to set DENO_DIR and call the batch file instead.

@Echo off
SETLOCAL
set DENO_DIR=E:\deno\.deno
E:\deno\deno.exe %*
ENDLOCAL

While this did seem to work, vscode/the plugin wouldn't kill the process when vscode exited, which left it hanging in memory, and also locked workspace folders as "in-use" so they couldn't be deleted/renamed in explorer.

kitsonk added a commit to denoland/deno that referenced this issue Jul 27, 2021
@kitsonk
feat(lsp): ability to set DENO_DIR via settings (#11527)
667b026 
Ref: denoland/vscode_deno#287
kitsonk added a commit that referenced this issue Jul 27, 2021
@kitsonk
feat: add ability to set cache directory in settings (#477)
98355ce 
Closes #287
LumaKernel added a commit to LumaKernel/coc-denoland that referenced this issue Aug 7, 2021
@LumaKernel @kitsonk
@lucacasonato @Kirlovon @Liamolucko @ry @jsejcksn @CGQAQ @dsherret @hectormenendez @fannheyward @satyarohith @yaegassy @cvng
feat: merge v3.7.0 (#8)
fd7f096 
* feat: code lens for references (denoland#308)

* feat: disable most of builtin language service when deno enabled (denoland#307)

* 0.0.8

* feat: add applyCodeActionCommand command (denoland#312)

* fix: remove deno/applyCodeActionCommand (denoland#315)

* New high-res logo (denoland#274)

* feat: add implementations code lens configuration option (denoland#319)

* feat: add initialize workspace command (denoland#316)

* feat: support deno cache quick fix (denoland#322)

* chore: add screenshot to README (denoland#323)

* 0.0.9

* 0.0.10

* fix: typo in init command (denoland#327)

* feat: add a welcome screen for extension (denoland#329)

* feat: use preview instead of display for status (denoland#330)

* chore: README improvements (denoland#331)

* Release 3.0.0, canary is now main (denoland#332)

* 3.0.1

* Fix typo (denoland#337)

Grammar + context

* chore: activate extension on command (denoland#336)

* docs: recommend import_map.json instead of import-map.json (denoland#340)

Resolves denoland#338

* chore: move Releases.md to CHANGELOG.md for better marketplace integration (denoland#344)

Closes denoland#342

* feat: add deno.path setting (denoland#350)

* 3.1.0

* feat: read-add debug support (denoland#351)

Co-authored-by: CGQAQ <[email protected]>

* feat: add settings to affect completions (denoland#368)

* fix: manual `deno` command resolution on windows. (denoland#367)

Fixes denoland#361

* 3.2.0

* feat: support for relative path resolution (using workspaces) in deno.path (denoland#381)

Co-authored-by: Kitson Kelly <[email protected]>

* feat: add version notification message (denoland#383)

* feat: add restart language server command (denoland#385)

Resolves denoland#372

* feat: add support for import registry completions (denoland#380)

* 3.3.0

* typo in ImportCompletions.md (denoland#390)

* fix: activate on reloadImportRegistries command (denoland#407)

Fixes: denoland#394

* feat: handle per resource configuration (denoland#411)

Requires Deno with denoland/deno#10488.

Ref: denoland#348 
Resolves: denoland#314
Resolves: denoland#297

* feat: add internalDebug config flag (denoland#406)

Also integrate upstream formatting changes in deno fmt.

Ref: denoland/deno#10368

* 3.4.0

* feat: recognise json(c) & markdown files (denoland#404)

* 3.5.0

* docs: fix broken link in README (denoland#426)

* feat: support registry auto discovery (denoland#427)

* fix: bump semver of extension (denoland#429)

* 3.5.1

* feat: add support for tasks and test code lens (denoland#436)

* 3.6.0

* fix: update packaging and pin vsce version (denoland#440)

Fixes denoland#439

* 3.6.1

* feat: add support for import map in test code lens (denoland#446)

* fix: activate extension on markdown / json / jsonc (denoland#447)

* fix: setting then clearing "deno.path" config should not use empty string for path (denoland#452)

* fix: better handling when language server fails to start (denoland#454)

* 3.7.0

* fix: remove trailing slash in example (denoland#471)

* chore: remove test header from bug report issue template (denoland#479)

* feat: add ability to set cache directory in settings (denoland#477)

Closes denoland#287

* fix: properly handle plugin configuration at startup (denoland#474)

Fixes denoland#473

Co-authored-by: Kitson Kelly <[email protected]>
Co-authored-by: Luca Casonato <[email protected]>
Co-authored-by: Kirill Reunov <[email protected]>
Co-authored-by: Liam Murphy <[email protected]>
Co-authored-by: Ryan Dahl <[email protected]>
Co-authored-by: Jesse Jackson <[email protected]>
Co-authored-by: CGQAQ <[email protected]>
Co-authored-by: David Sherret <[email protected]>
Co-authored-by: Hector Menendez <[email protected]>
Co-authored-by: Heyward Fann <[email protected]>
Co-authored-by: Satya Rohith <[email protected]>
Co-authored-by: yaegassy <[email protected]>
Co-authored-by: Cedric Vangout <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kitsonk kitsonk

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add ability to set cache directory in settings kitsonk/vscode_deno
3 participants
@tehbeard @kitsonk @Tzahile