feat(unstable): remove --unstable-workspaces flag #21891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
changed the title
dsherret
reviewed
Jan 10, 2024
cli/args/flags.rs
Outdated
| @@ -1032,13 +1031,12 @@ fn clap_root() -> Command { | |||
| .global(true), | |||
| ) | |||
| .arg( | |||
| // NOTE(bartlomieju): not used anymore, but kept for CLI compatibility between | |||
There was a problem hiding this comment.
I think it's not too big of a deal to just remove this? It's unstable and not a lot of people are using it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flag is kept for existing CLI compatibility, but is not required anymore.
The workspaces feature is still considered unstable and can change. Requiring this flag
hinders DX.