Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP can't resolve import_maps in workspaces when using --unstable-workspaces #21769

Closed
Tracked by #22942
igl opened this issue Jan 3, 2024 · 3 comments
Closed
Tracked by #22942
Labels
bug Something isn't working correctly lsp related to the language server

Comments

@igl
Copy link

igl commented Jan 3, 2024

Versions:

  • Deno 1.39.1
  • vscode_deno 3.31.0

Description:

When using vscode with the latest vscode_deno extension, the LSP can not resolve my import_map defined in the workspaces individual deno.json files.

The Editor will show: Relative import path "std/uuid/mod.ts" not prefixed with / or ./ or ../deno(import-prefix-missing)
Executing the code using deno run -A --unstable-workspaces src/api/main.ts works as intended.

Code for Repro: https://github.com/igl/deno-workspace-playground/tree/lsp-bug

Screenshot:
image

@kt3k kt3k added the bug Something isn't working correctly label Jan 3, 2024
@bartlomieju
Copy link
Member

@nayeemrmn is this something you could look at?

@Hajime-san
Copy link
Contributor

Hajime-san commented Feb 17, 2024

The --unstable-workspaces flag removed, isn’t it?

#21891

It's my misunderstanding, it removed only flag, not feature.

@lucacasonato lucacasonato added the lsp related to the language server label Jun 18, 2024
@igl
Copy link
Author

igl commented Jul 12, 2024

Just tested in 1.45.1 and it works! :D

@igl igl closed this as completed Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly lsp related to the language server
Projects
None yet
Development

No branches or pull requests

5 participants