refactor(ext/http): remove op_http_read #16096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacasonato
force-pushed
the
remove_op_http_read
branch
from
a7f6fdc to
e0c9048
Compare
We can use Resource::read_return & op_read instead. This allows HTTP request bodies to participate in FastStream. To make this work, `readableStreamForRid` required a change to allow non auto-closing resources to be handled. This required some minor changes in our FastStream paths in ext/http and ext/flash.
lucacasonato
force-pushed
the
remove_op_http_read
branch
from
e0c9048 to
6ec0e11
Compare
lucacasonato
commented
Sep 29, 2022
Comment on lines
-39
to
-44
| fn read(self: Rc<Self>, buf: ZeroCopyBuf) -> AsyncResult<usize> { | ||
| Box::pin(async move { | ||
| let (nread, _) = self.read_return(buf).await?; | ||
| Ok(nread) | ||
| }) | ||
| } |
There was a problem hiding this comment.
This caused a totally unnecessary extra Box::pin in every op_read call, and as such has been removed :)
aapoalas
reviewed
Sep 30, 2022
aapoalas
reviewed
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use Resource::read_return & op_read instead. This allows HTTP
request bodies to participate in FastStream.
To make this work,
readableStreamForRidrequired a change to allow nonauto-closing resources to be handled. This required some minor changes
in our FastStream paths in ext/http and ext/flash.
Blocked on #16095
Towards #16046