fix(runtime): no FastStream for unrefable streams #16095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unrefable streams are not immediately compatible with FastStreams, because it would require all FastStream implementers to support unref streaming. This is not reasonable at this time, so for now we opt all unrefable streams out of the FastStreams optimization by removing the `[_maybeRid]` marker from these `ReadableStream` objects.
lucacasonato
force-pushed
the
unref_no_faststream
branch
from
371f00c to
d487494
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unrefable streams are not immediately compatible with FastStreams,
because it would require all FastStream implementers to support
unref streaming. This is not reasonable at this time, so for now we opt
all unrefable streams out of the FastStreams optimization by removing
the
[_maybeRid]marker from theseReadableStreamobjects.