Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn ip list large and added fqdn parameter #30646

Conversation

franciscojoseabellan
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Description

Warn the users when the Qualys API fails because Demisto cannot process too large parameters in the URL of HTTP calls,
Also added fqdn parameter that was lacking in the parameter list of the HTTP call

Must have

  • Tests
  • Documentation

@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Nov 3, 2023
@content-bot content-bot changed the base branch from master to contrib/franciscojoseabellan_warn_IP_list_large-1 November 3, 2023 12:35
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @sapirshuker will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Hi @franciscojoseabellan, thanks for contributing to a Cortex XSOAR supported pack. To receive credit for your generous contribution please follow this link.

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. labels Nov 3, 2023
Fixed bug with split lines
@franciscojoseabellan
Copy link
Contributor Author

franciscojoseabellan commented Nov 6, 2023

I am going to close this pull request, because I thought, in a previous PR that I made, that I needed to do more work and I created this PR

MosheEichler in the comment #30341 has just confirmed that I don't need to do more work and they will be responsible of the PR

So I close this PR because it is redundant,

Sorry for the inconvenience,

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants