fix added warning IP list too large #30217

franciscojoseabellan · 2023-10-17T09:06:27Z

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

In Progress
Ready
In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Must have

Tests
Documentation

CLAassistant · 2023-10-17T09:06:34Z

All committers have signed the CLA.

content-bot · 2023-10-17T09:09:16Z

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @MosheEichler will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

content-bot · 2023-10-17T09:09:17Z

Hi @franciscojoseabellan, thanks for contributing to a Cortex XSOAR supported pack. To receive credit for your generous contribution please follow this link.

MosheEichler

Hi @franciscojoseabellan,
Thank you for your contribution!
Good work :)

Please bump the pack version in the pack_metadata.json file and add notes describing your changes to a new Release Notes file.
To do that, please run the demisto-sdk update-release-notes command - for more information please see: https://xsoar.pan.dev/docs/concepts/demisto-sdk#update-release-notes.

Please feel free to reach out to me with any questions - I'm available here or on slack :)
Thanks again

franciscojoseabellan · 2023-10-18T11:55:36Z

Hello MosheEichler

After executing the command, we got notified that no rellevant changes were made in this commit

MosheEichler · 2023-10-18T13:23:06Z

Packs/qualys/Integrations/Qualysv2/Qualysv2.py

@@ -1337,6 +1337,7 @@
            "use_ip_nt_range_tags_include", "use_ip_nt_range_tags_exclude",
            "active",
            "scanners_in_network",
+            "fqdn",


why did you add it?

I added it because Qualysv2 lacked the parameter fqdn
If not added, Demisto returns an error:

MosheEichler · 2023-10-18T13:23:23Z

Hello MosheEichler

After executing the command, we got notified that no rellevant changes were made in this commit

Hey @franciscojoseabellan
Don't wory I'll take care on it.
Please see my comment.

MosheEichler · 2023-10-19T06:45:47Z

Packs/qualys/Integrations/Qualysv2/Qualysv2.py

@@ -1488,7 +1489,10 @@ def __init__(self, base_url, username, password, verify=True, proxy=False, heade

    @staticmethod
    def error_handler(res):
-        err_msg = f"Error in API call [{res.status_code}] - {res.reason}"
+        err_msg = ""
+        if res.status_code == 414 or res.status_code == 520:


Can you plesae add a reference (API documentetion) for this error (with status codes)?

It is an error when we provide to the ip field an string of approximately between 5000 and 12000 characters containing IP, we receive a 414 error from the API, when we provide more than approximately 12000 characters containing IPs, we receive a 520 error,

We do not know if it is an error related to the Demisto processing of large characters in the URL

MosheEichler · 2023-10-19T11:54:04Z

Hi @franciscojoseabellan, the code looks good!

We're ready for a demo. Please check this page, and let me know when you're available for one over DFIR.

MosheEichler · 2023-10-19T14:13:51Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hey @franciscojoseabellan
Please sing the CLA

franciscojoseabellan · 2023-10-19T15:20:44Z

Hi @MosheEichler,

Can I find you with the same username (MosheEichler) on Slack to talk about the demo?

Regards,

MosheEichler · 2023-10-22T08:07:24Z

Hi @MosheEichler,

Can I find you with the same username (MosheEichler) on Slack to talk about the demo?

Regards,

Yes. search Moshe Eichler.

franciscojoseabellan · 2023-10-24T09:37:15Z

@MosheEichler

Do you know when this PR would be incorporated in the master branch of demisto?

Thanks for your help

Regards,

* fix added warning IP list too large (#30217) * fix added warning * Added fqdn parameter to qualys-schedule-scan-create command * flake8 * pre commit * RN * Update Packs/qualys/ReleaseNotes/2_0_6.md Co-authored-by: ShirleyDenkberg <[email protected]> * fix description * docker * RN * SysAid add get file (#30718) * SysAid add get file (#30583) * SysAid add get file * Fixed error SysAid add get file * docker * Add file output * Update Packs/SysAid/ReleaseNotes/1_0_13.md Co-authored-by: ShirleyDenkberg <[email protected]> * Update Packs/SysAid/Integrations/SysAid/SysAid.yml Co-authored-by: ShirleyDenkberg <[email protected]> * Update Packs/SysAid/Integrations/SysAid/SysAid.yml Co-authored-by: ShirleyDenkberg <[email protected]> * Update Packs/SysAid/Integrations/SysAid/README.md Co-authored-by: ShirleyDenkberg <[email protected]> * fixed UT --------- Co-authored-by: Giorgio <[email protected]> Co-authored-by: MosheEichler <[email protected]> Co-authored-by: Moshe Eichler <[email protected]> Co-authored-by: ShirleyDenkberg <[email protected]> * update conf file (#30743) * remove/change values (#30728) * SentinelOne v 3 2 12 (#30740) * SentinelOne v 3 2 12 (#30626) * Bug Fixes * updated the docker image * updated the release notes * making chages in threat request call * review comment fix * fixed release notes * docker --------- Co-authored-by: munna-metron <[email protected]> Co-authored-by: MosheEichler <[email protected]> * Netcraft Revamp (#29527) * init * started fetch * finished fetch * name changes * fixed output in yml * added command names * mirroring part 1 * added incident type * fixed incident type * fethcing logic works! * cmnd: netcraft-attack-report * cmnd: netcraft-attack-report complete * reference new pack in old * cmnd: netcraft-attack-report complete * session changes * added classifier * added commands * commands continued * commands continued * order change * test-module * examples init * session changes * pre update * finished code * added TPB * unit-tests init * test_data TO BE DELETED * test_data TO BE DELETED * test_data complete * test_data.py complete * unit-tests continued * unit-tests complete * fixed KeyError bug * fixed SubmissionNextToken bug * fixed pagination bug * remove unused test data * improved UI * silence secret ignore * silence line-too-long * silence secret ignore * added readme; fixed png * tests/format complete * default args * session changes * session changes * CR changes * finished docs * fix docs * fix docs * added layout * clearer description * add error for no file * add error for no file * demo changes part 1 * demo changes part 2 * demo changes part 3 * demo changes part 4 * demo changes part 5 * fixed unit-tests * update escalate docs * authorise => authorize * match case => if-elif * CR changes * Apply suggestions from code review Co-authored-by: ShirleyDenkberg <[email protected]> * fixed unit-tests * remove trailing whitespace * try running build * fixed upload bug * name change to avoid conflict * pack readme part 1 * release notes * add image * removed unnecessary files * cleaned build problems * pack readme part 2 * readme complete * readme complete * added layout, mapper, type; not formatted * capitalize 'service' * get_file_path * trial fix for unittests * fixed unit-tests * update docker * small changes * doc review changes * update TPB * silence secret detections * classifier fixed * demo changes * demo changes * small change * UI works * fix tests and docs * update docker * added types to yaml * fixed file submit bug * layout for xsoar only * build wars: round 1 * build wars: round 2 * build wars: round 3 * build wars: round 4 * build wars: round 5 * build wars: round 6 * build wars: round 7 * Update conf.json * remove email address * fix TPB * incease retry-interval * raised timeout threshold * update docker * raised from_version --------- Co-authored-by: ShirleyDenkberg <[email protected]> * docker * change map * change scan * revert --------- Co-authored-by: franciscojoseabellan <[email protected]> Co-authored-by: MosheEichler <[email protected]> Co-authored-by: Moshe Eichler <[email protected]> Co-authored-by: ShirleyDenkberg <[email protected]> Co-authored-by: Giorgio <[email protected]> Co-authored-by: Israel Lappe <[email protected]> Co-authored-by: Adi Bamberger Edri <[email protected]> Co-authored-by: munna-metron <[email protected]> Co-authored-by: Jacob Levy <[email protected]>

fix added warning

5955404

content-bot added Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Oct 17, 2023

content-bot changed the base branch from master to contrib/franciscojoseabellan_warn_IP_list_large October 17, 2023 09:08

content-bot assigned MosheEichler Oct 17, 2023

content-bot requested a review from MosheEichler October 17, 2023 09:09

content-bot added Community Contribution Form Filled Whether contribution form filled or not. labels Oct 17, 2023

MosheEichler reviewed Oct 17, 2023

View reviewed changes

MosheEichler added the pending-contributor The PR is pending the response of its creator label Oct 17, 2023

Added fqdn parameter to qualys-schedule-scan-create command

bef69fe

MosheEichler reviewed Oct 18, 2023

View reviewed changes

MosheEichler reviewed Oct 19, 2023

View reviewed changes

MosheEichler added the pending-demo Demo pending label Oct 19, 2023

MosheEichler approved these changes Oct 19, 2023

View reviewed changes

MosheEichler merged commit d9b5a01 into demisto:contrib/franciscojoseabellan_warn_IP_list_large Oct 23, 2023
13 of 14 checks passed

content-bot mentioned this pull request Oct 23, 2023

fix added warning IP list too large #30341

Merged

5 tasks

franciscojoseabellan mentioned this pull request Nov 3, 2023

Patch 1 franciscojoseabellan/content#1

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix added warning IP list too large #30217

fix added warning IP list too large #30217

franciscojoseabellan commented Oct 17, 2023 •

edited

Loading

CLAassistant commented Oct 17, 2023 •

edited

Loading

content-bot commented Oct 17, 2023

content-bot commented Oct 17, 2023

MosheEichler left a comment

franciscojoseabellan commented Oct 18, 2023 •

edited

Loading

MosheEichler Oct 18, 2023 •

edited

Loading

franciscojoseabellan Oct 19, 2023

MosheEichler commented Oct 18, 2023

MosheEichler Oct 19, 2023 •

edited

Loading

franciscojoseabellan Oct 19, 2023

MosheEichler commented Oct 19, 2023

MosheEichler commented Oct 19, 2023

franciscojoseabellan commented Oct 19, 2023

MosheEichler commented Oct 22, 2023

franciscojoseabellan commented Oct 24, 2023

fix added warning IP list too large #30217

fix added warning IP list too large #30217

Conversation

franciscojoseabellan commented Oct 17, 2023 • edited Loading

Contributing to Cortex XSOAR Content

Status

Related Issues

Description

Must have

CLAassistant commented Oct 17, 2023 • edited Loading

content-bot commented Oct 17, 2023

content-bot commented Oct 17, 2023

MosheEichler left a comment

Choose a reason for hiding this comment

franciscojoseabellan commented Oct 18, 2023 • edited Loading

MosheEichler Oct 18, 2023 • edited Loading

Choose a reason for hiding this comment

franciscojoseabellan Oct 19, 2023

Choose a reason for hiding this comment

MosheEichler commented Oct 18, 2023

MosheEichler Oct 19, 2023 • edited Loading

Choose a reason for hiding this comment

franciscojoseabellan Oct 19, 2023

Choose a reason for hiding this comment

MosheEichler commented Oct 19, 2023

MosheEichler commented Oct 19, 2023

franciscojoseabellan commented Oct 19, 2023

MosheEichler commented Oct 22, 2023

franciscojoseabellan commented Oct 24, 2023

franciscojoseabellan commented Oct 17, 2023 •

edited

Loading

CLAassistant commented Oct 17, 2023 •

edited

Loading

franciscojoseabellan commented Oct 18, 2023 •

edited

Loading

MosheEichler Oct 18, 2023 •

edited

Loading

MosheEichler Oct 19, 2023 •

edited

Loading