Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes and enchancements in integration #30292

Merged
merged 25 commits into from
Nov 8, 2023
Merged

Bug fixes and enchancements in integration #30292

merged 25 commits into from
Nov 8, 2023

Conversation

cyble-dev
Copy link
Contributor

@cyble-dev cyble-dev commented Oct 18, 2023 •
edited
Loading

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Must have

  • Tests
  • Documentation

@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Partner Support Level Indicates that the contribution is for Partner supported pack labels Oct 18, 2023
@content-bot content-bot changed the base branch from master to contrib/cyble-dev_cyble-enhancements October 18, 2023 09:52
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @sapirshuker will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@cyble-dev cyble-dev changed the title Cyble enhancements Bug fixes and enchancements in integration Oct 18, 2023
@content-bot content-bot added Partner-Approved Contribution Form Filled Whether contribution form filled or not. Partner labels Oct 18, 2023
@cyble-dev cyble-dev mentioned this pull request Oct 18, 2023
Closed
5 tasks
@RosenbergYehuda RosenbergYehuda requested review from RosenbergYehuda and removed request for sapirshuker October 18, 2023 10:15
@RosenbergYehuda
Copy link
Contributor

RosenbergYehuda commented Oct 18, 2023 •
edited
Loading

Hello @cyble-dev, thank you for your resubmission.
As you can see in the GitHub actions, in the "ci/circleci: Run Validations" section, that there are many validation failures.Do you know how to use our demisto-sdk format?
If yes, please try that and see if the errors are gone.Please check after that that everything is in the right place and working.

@RosenbergYehuda
Copy link
Contributor

RosenbergYehuda commented Oct 18, 2023 via email •
edited
Loading

@yaakovpraisler yaakovpraisler removed their request for review November 5, 2023 20:36
@melamedbn
Copy link
Contributor

Hi @cyble-dev,

There are still things that should be addressed as discussed in our meeting.

  1. Remove the hardcoded values from the playbook inputs.
  2. Add description to the inputs.
  3. Add another input for the 'limit' argument so the user will be able to choose the limit.

Best regards,
Ben

@cyble-dev
Copy link
Contributor Author

Hi @melamedbn,
Can we get on a quick call right now?

@cyble-dev
Copy link
Contributor Author

Hi @melamedbn,
I have made the changes you suggested. Please proceed.

@cyble-dev
Copy link
Contributor Author

Hi @edik24, @melamedbn & @RosenbergYehuda,
I have removed the playbook’s changes and updated the whole pack. Please proceed.

Please let me know if you have any query.

melamedbn
melamedbn reviewed Nov 8, 2023
View reviewed changes
Packs/CybleEventsV2/doc_files/Cyble_Vision_Alert_V2.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the image as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall I keep the empty doc_files folder or remove it as well?

@melamedbn
Copy link
Contributor

@cyble-dev,

Just saw that the current image isn't good. so let's keep the new image and delete the old one.

@cyble-dev
Copy link
Contributor Author

cyble-dev commented Nov 8, 2023 •
edited
Loading

@cyble-dev,

Just saw that the current image isn't good. so let's keep the new image and delete the old one.

oh, okay @melamedbn
So no modification is required, right?
We are moving forward as it is now.

@RosenbergYehuda RosenbergYehuda merged commit 00e6480 into demisto:contrib/cyble-dev_cyble-enhancements Nov 8, 2023
11 of 12 checks passed
@content-bot content-bot mentioned this pull request Nov 8, 2023
Merged
5 tasks
RosenbergYehuda added a commit that referenced this pull request Nov 8, 2023
@content-bot @cyble-dev @RosenbergYehuda
Bug fixes and enchancements in integration (#30751)
98bece4 
* Bug fixes and enchancements in integration (#30292)

* New PR with all the changes

* Updated RN

* Fixed issues in files' format

* Fixed fieldnames

* Fixed field's name in layout file

* Fixed field's name in layout file

* Fixed field's name in layout file

* Removed -Layout suffix

* Updated layout file

* Formatted files

* Fixed playbook

* Updated RNs

* Made changes in object files, uploading updated ones

* Formatted files and bugs, test failure fixes

* Updated RN, tests, playbook changes and formatting

* Updated RN

---------

Co-authored-by: Yehuda Rosenberg <[email protected]>

* RN

* mistake

* RN

---------

Co-authored-by: cyble-dev <[email protected]>
Co-authored-by: Yehuda Rosenberg <[email protected]>
Co-authored-by: Yehuda <[email protected]>
@cyble-dev cyble-dev deleted the cyble-enhancements branch November 9, 2023 10:25
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
@content-bot @cyble-dev @RosenbergYehuda
Bug fixes and enchancements in integration (#30751)
156396c 
* Bug fixes and enchancements in integration (#30292)

* New PR with all the changes

* Updated RN

* Fixed issues in files' format

* Fixed fieldnames

* Fixed field's name in layout file

* Fixed field's name in layout file

* Fixed field's name in layout file

* Removed -Layout suffix

* Updated layout file

* Formatted files

* Fixed playbook

* Updated RNs

* Made changes in object files, uploading updated ones

* Formatted files and bugs, test failure fixes

* Updated RN, tests, playbook changes and formatting

* Updated RN

---------

Co-authored-by: Yehuda Rosenberg <[email protected]>

* RN

* mistake

* RN

---------

Co-authored-by: cyble-dev <[email protected]>
Co-authored-by: Yehuda Rosenberg <[email protected]>
Co-authored-by: Yehuda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RosenbergYehuda RosenbergYehuda RosenbergYehuda approved these changes

@melamedbn melamedbn melamedbn approved these changes

Assignees

@melamedbn melamedbn

@edik24 edik24

@RosenbergYehuda RosenbergYehuda

Labels
Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved External PR Partner Support Level Indicates that the contribution is for Partner supported pack Partner Partner-Approved Security Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cyble-dev @content-bot @RosenbergYehuda @melamedbn @CLAassistant @sapirshuker @edik24