Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes and enchancements in integration #30049

Closed
wants to merge 26 commits into from
Closed

Bug fixes and enchancements in integration #30049

wants to merge 26 commits into from

Conversation

content-bot
Copy link
Collaborator

Original External PR

external pull request

Contributor

@cyble-dev

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Must have

  • Tests
  • Documentation

@cyble-dev @ckaadic
@RosenbergYehuda @ShirleyDenkberg
Bug fixes and enchancements in integration (#29556)
da98aef 
* 1. Hide CVV/Expiry feature
2. Fixed duplicate alerts issue
3. Issue with configuring playbook fixed

* Testing and validation

* Mde list indicator filter (#29338)

* init indicator filter

* release notes

* latest docker image

* updated docker image

* minor fixes

* reslove conflicts

* resolve version conflicts

* silence linter

* format

* docker

* Apply suggestions from Shirley

Co-authored-by: ShirleyDenkberg <[email protected]>

* add period

* change phrase

* adding    "is_mockable": false

* Added Mirroring Functionality

* Added get-mapping-fileds command in .yml

* docker

* try change test playbook

* removing extra files

* deleting last file

* Implemented review changes

* Added test for update-incident command

* Added Release Notes

* Updated Release notes and implement review changes

* Fixed and Updated Release Notes

* Added Done header in playbook, retitled card hiding feature, updated release notes

---------

Co-authored-by: ckaadic <[email protected]>
Co-authored-by: Yehuda <[email protected]>
Co-authored-by: Yehuda Rosenberg <[email protected]>
Co-authored-by: ShirleyDenkberg <[email protected]>
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! Partner Contribution Form Filled Whether contribution form filled or not. pending-contributor The PR is pending the response of its creator Partner Support Level Indicates that the contribution is for Partner supported pack Internal PR Security Review Partner-Approved labels Oct 4, 2023
ShirleyDenkberg
ShirleyDenkberg reviewed Oct 5, 2023
View reviewed changes
Packs/CybleEventsV2/Integrations/CybleEventsV2/CybleEventsV2.yml Outdated Show resolved Hide resolved
Packs/CybleEventsV2/Integrations/CybleEventsV2/CybleEventsV2.yml Outdated Show resolved Hide resolved
Packs/CybleEventsV2/Integrations/CybleEventsV2/CybleEventsV2.yml Outdated Show resolved Hide resolved
Packs/CybleEventsV2/Integrations/CybleEventsV2/CybleEventsV2.yml Outdated Show resolved Hide resolved
Packs/CybleEventsV2/Integrations/CybleEventsV2/README.md Outdated Show resolved Hide resolved
Packs/CybleEventsV2/ReleaseNotes/1_0_2.md Outdated Show resolved Hide resolved
Packs/CybleEventsV2/ReleaseNotes/1_0_2.md Show resolved Hide resolved
Packs/CybleEventsV2/ReleaseNotes/1_0_2.md Show resolved Hide resolved
Packs/CybleEventsV2/ReleaseNotes/1_0_2.md Show resolved Hide resolved
Packs/CybleEventsV2/ReleaseNotes/1_0_2.md Outdated Show resolved Hide resolved
@ShirleyDenkberg ShirleyDenkberg self-assigned this Oct 5, 2023
@ShirleyDenkberg
Copy link
Contributor

@RosenbergYehuda Doc review completed.

@RosenbergYehuda
Copy link
Contributor

Hey @cyble-dev,
i'm trying to merge your contribution, and i'm facing these issue, please let me know if you want to modify the layout and send me the a new version, or to make this pack available on XSOAR only.

@cyble-dev
Copy link
Contributor

Hello @RosenbergYehuda,
Yes, you can make this pack available on XSOAR only.

@cyble-dev
Copy link
Contributor

Hi @RosenbergYehuda,
Can you please tell me by when can we expect the updated app to be available on marketplace?
I need to update the upper management.
Thanks.

@RosenbergYehuda
Copy link
Contributor

Hello @cyble-dev,
Unfortunately this PR was not ready to be merged yet, there were many errors in the build. Since I accidentally already merged it into an internal PR, I had to fix all those errors. Right now we have 2 remaining errors that @melamedbn and I are trying to figure out. Due to the situation here in Israel, things may take longer. I don't have a specific timeline for when it will be merged.

@cyble-dev
Copy link
Contributor

Sure @RosenbergYehuda, I understand and I am sorry about the situation there. I sincerely pray that everything will become okay there soon. Thank You and @melamedbn for your help.

@RosenbergYehuda
Copy link
Contributor

Hi @cyble-dev,

Apologies for the delay on this PR.
We've tried several times but are still running into issues with the mapper, incident type, and layout configuration.

Could you please upload the latest version from the internal PR and confirm whether the mapper, incident type, and layout are set up as you intended? Does this current version work correctly for you?

Alternatively, please feel free to open a new contribution with the most recent working version you have, and we can review and merge that instead.

@RosenbergYehuda
Copy link
Contributor

Alternatively, You can send me your latest working incident type, incoming mapper, and layout files. I will compare them to what we have to help identify the issue. Having your known working versions will assist troubleshooting the problems we are seeing.

@cyble-dev
Copy link
Contributor

cyble-dev commented Oct 18, 2023 •
edited
Loading

Hello @RosenbergYehuda,
As per your suggestion, I have created a fresh new PR with the additional changes I had, and the latest Layout, Mappers, and Incident type.
In the new PR, I have also included all the changes and modifications you have done in this internal PR to fix the issues.

The new PR: #30292

cc: @melamedbn, @edik24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShirleyDenkberg ShirleyDenkberg ShirleyDenkberg left review comments

@RosenbergYehuda RosenbergYehuda Awaiting requested review from RosenbergYehuda

Assignees

@melamedbn melamedbn

@ShirleyDenkberg ShirleyDenkberg

@edik24 edik24

@RosenbergYehuda RosenbergYehuda

Labels
Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved Internal PR Partner Support Level Indicates that the contribution is for Partner supported pack Partner Partner-Approved pending-contributor The PR is pending the response of its creator Security Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@content-bot @ShirleyDenkberg @RosenbergYehuda @cyble-dev @melamedbn @edik24