Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Marketplace Contribution] Content Testing - Content Pack Update #29308

Conversation

content-bot
Copy link
Collaborator

Original External PR

external pull request

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Contributor

@rurhrlaub

Notes

UnitTestLayout picked up script ID GUIDs in some cases and several scripts also picked up GUIDs. All replaced by name references:

UnitTestSetField
UnitTestLoadFieldsList
UnitTestLoadContextList
UnitTestSaveContextList
UnitTestSaveFieldsList
UnitTestLoadContext
UnitTestLoadFields
UnitTestCoverage
UnitTest
UnitTestPlaybookAnalyzer
ContentDependencies
UpgradeCheck
ChangeHistory

Video Link

Short demo video of the Pack usage. Speeds up the review. Optional but recommended. Use a video sharing service such as Google Drive or YouTube.

)

* "contribution update to pack "Content Testing""

* Update incidentfield-Content_Testing_Unit_Test_Playbooks.json

 Fixed   "script": "UnitTestMultiSelect",

* remove the wired changes in the pr

* help the build pass

* validate

* avoiding breaking changes

* docker image

* docker image

---------

Co-authored-by: David Uhrlaub <[email protected]>
Co-authored-by: Yehuda <[email protected]>
Co-authored-by: Yehuda Rosenberg <[email protected]>
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! docs-approved post-demo Community Support Level Indicates that the contribution is for Community supported pack Internal PR Security Review labels Aug 29, 2023
@RosenbergYehuda RosenbergYehuda merged commit 2be5018 into master Aug 30, 2023
@RosenbergYehuda RosenbergYehuda deleted the contrib/xsoar-contrib_rurhrlaub-contrib-ContentTesting-7 branch August 30, 2023 19:25
xsoar-bot added a commit to xsoar-contrib/content that referenced this pull request Oct 5, 2023
…isto#29308)

* [Marketplace Contribution] Content Testing - Content Pack Update (demisto#28959)

* "contribution update to pack "Content Testing""

* Update incidentfield-Content_Testing_Unit_Test_Playbooks.json

 Fixed   "script": "UnitTestMultiSelect",

* remove the wired changes in the pr

* help the build pass

* validate

* avoiding breaking changes

* docker image

* docker image

---------

Co-authored-by: David Uhrlaub <[email protected]>
Co-authored-by: Yehuda <[email protected]>
Co-authored-by: Yehuda Rosenberg <[email protected]>

* change default

* add default value for unrequited argument

* RN

* fix validate

---------

Co-authored-by: xsoar-bot <[email protected]>
Co-authored-by: David Uhrlaub <[email protected]>
Co-authored-by: Yehuda <[email protected]>
Co-authored-by: Yehuda Rosenberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Support Level Indicates that the contribution is for Community supported pack Contribution Thank you! Contributions are always welcome! docs-approved Internal PR post-demo Security Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants