[Marketplace Contribution] Content Testing - Content Pack Update #28959

xsoar-bot · 2023-08-14T15:13:22Z

Status

In Progress
Ready
In Hold - (Reason for hold)

Contributor

Notes

UnitTestLayout picked up script ID GUIDs in some cases and several scripts also picked up GUIDs. All replaced by name references:

UnitTestSetField
UnitTestLoadFieldsList
UnitTestLoadContextList
UnitTestSaveContextList
UnitTestSaveFieldsList
UnitTestLoadContext
UnitTestLoadFields
UnitTestCoverage
UnitTest
UnitTestPlaybookAnalyzer
ContentDependencies
UpgradeCheck
ChangeHistory

Video Link

Short demo video of the Pack usage. Speeds up the review. Optional but recommended. Use a video sharing service such as Google Drive or YouTube.

content-bot · 2023-08-14T15:15:41Z

Thank you for your contribution. Your generosity and caring are unrivaled! Rest assured - our content wizard @RosenbergYehuda will very shortly look over your proposed changes.

RosenbergYehuda

Great job @rurhrlaub!
I added some small fixes, please take a look.
If you have any questions, feel free to response back on my comments.

Packs/ContentTesting/Scripts/UnitTestCase/UnitTestCase.py

RosenbergYehuda · 2023-08-20T13:16:02Z

Packs/ContentTesting/Scripts/UnitTestCasePrep/UnitTestCasePrep.py

    try:
+        args = demisto.args()
+        testName = args.get("testName", "")


Why did you remove these 3 lines in to the 'try' block?
It does not need to be there beucus there is no scenario for it to fail, and the way it is now will not execute, because in the bottom the 'except Exception' is out of the 'try' block and we call 'testName', which is inside of the 'try' block.

Same here. No lines removed and exception still valid?

Sorry, please ignore this.

Hi @rurhrlaub, how are you?
I've messaged you via Slack. Is "David Uhrlaub" your username there?
I'm currently looking into this unusual problem of lines moving without your touch, and would greatly value your responses.

RosenbergYehuda · 2023-08-20T13:21:33Z

Packs/ContentTesting/Scripts/UnitTestLoadFieldsList/UnitTestLoadFieldsList.py

@@ -1,5 +1,6 @@
 import demistomock as demisto  # noqa: F401
 from CommonServerPython import *  # noqa: F401
+# Final Test: 6.10


I think this can be removed.

Suggested change

# Final Test: 6.10

RosenbergYehuda · 2023-08-20T13:23:17Z

Packs/ContentTesting/Scripts/UnitTestMultiSelect/UnitTestMultiSelect.py

@@ -1,6 +1,6 @@
 import demistomock as demisto  # noqa: F401
 from CommonServerPython import *  # noqa: F401
-
+# Final Test: 6.10


Can be removed, correct?

Suggested change

# Final Test: 6.10

RosenbergYehuda · 2023-08-20T13:24:52Z

Packs/ContentTesting/Scripts/UnitTestSaveContextList/UnitTestSaveContextList.py

@@ -1,5 +1,6 @@
 import demistomock as demisto  # noqa: F401
 from CommonServerPython import *  # noqa: F401
+# Final Test: 6.10


RosenbergYehuda · 2023-08-20T13:25:23Z

Packs/ContentTesting/Scripts/UnitTestSaveFieldsList/UnitTestSaveFieldsList.py

@@ -1,5 +1,6 @@
 import demistomock as demisto  # noqa: F401
 from CommonServerPython import *  # noqa: F401
+# Final Test: 6.10


RosenbergYehuda · 2023-08-20T13:34:58Z

Packs/ContentTesting/Scripts/UnitTestSetField/UnitTestSetField.py

@@ -1,5 +1,6 @@
 import demistomock as demisto  # noqa: F401
 from CommonServerPython import *  # noqa: F401
+# Final Test: 6.10


RosenbergYehuda · 2023-08-20T13:35:18Z

Packs/ContentTesting/Scripts/UnitTestSubplaybookPrep/UnitTestSubplaybookPrep.py

@@ -1,5 +1,6 @@
 import demistomock as demisto  # noqa: F401
 from CommonServerPython import *  # noqa: F401
+# Final Test: 6.10


melamedbn · 2023-08-22T07:52:25Z

Dear @rurhrlaub,

I hope this message finds you well. Firstly, I want to express my appreciation for your efforts in contributing to the content. Your dedication to the project is evident, and I wanted to share a couple of suggestions to further enhance the quality of the work:

Misconfigurations

In the layout, there are buttons that have an ID instead of the script name which cause a failure. Please use the script name instead of the id.
Can be found in the following buttons:
Check Content Pack Upgrade Impacts on Custom Content (Content Assessment tab)
Get Commit History for Local Changes (Content Assessment tab)
All of the 'Content Testing' and 'Playbook Analysis' tab buttons.
The incident field has a change relating to the script name, please use the script name instead of the ID. (screenshot attached)

I trust that these suggestions will be valuable in fine-tuning the content. Once again, thank you for your commitment and hard work. I'm confident that with these minor tweaks, we'll be able to deliver an even more polished product to our users.

Warm regards,
Ben

Fixed "script": "UnitTestMultiSelect",

rurhrlaub · 2023-08-22T14:25:28Z

Fixed the field. Not sure how it changed. The layout was resubmitted for this revision because many of the scriptIDs had changed from name to ID. Looking at github, the layout buttons all have a script name, so I do not follow your first comment.

…

On Tue, Aug 22, 2023 at 2:52 AM Ben Melamed ***@***.***> wrote: Dear @rurhrlaub <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_rurhrlaub&d=DwMCaQ&c=V9IgWpI5PvzTw83UyHGVSoW3Uc1MFWe5J8PTfkrzVSo&r=c4k2lAmoL_NLIKl9qYVpJ-M0mh6RKSaHBNpd5VoXXPE&m=K5yMWx0Fy7gwf5WBwhAEhe7945xj1EJZjk8JVov22kqTe5HbGQL8Ca4-K4JQieS0&s=5yUHPGOrXxkIaR3MXMepezcGwv2gcMs-l5PqeRaP3ig&e=> , I hope this message finds you well. Firstly, I want to express my appreciation for your efforts in contributing to the content. Your dedication to the project is evident, and I wanted to share a couple of suggestions to further enhance the quality of the work: Misconfigurations 1. In the layout, there are buttons that have an ID instead of the script name which cause a failure. Please use the script name instead of the id. Can be found in the following buttons: *Check Content Pack Upgrade Impacts on Custom Content (Content Assessment tab) Get Commit History for Local Changes (Content Assessment tab) All of the 'Content Testing' and 'Playbook Analysis' tab buttons.* [image: image] <https://urldefense.proofpoint.com/v2/url?u=https-3A__user-2Dimages.githubusercontent.com_28757135_262273179-2D5722e90f-2D1ddf-2D49a2-2D8fd7-2D62b39fda55d3.png&d=DwMCaQ&c=V9IgWpI5PvzTw83UyHGVSoW3Uc1MFWe5J8PTfkrzVSo&r=c4k2lAmoL_NLIKl9qYVpJ-M0mh6RKSaHBNpd5VoXXPE&m=K5yMWx0Fy7gwf5WBwhAEhe7945xj1EJZjk8JVov22kqTe5HbGQL8Ca4-K4JQieS0&s=juvFCEwApCuXyRgjtku1YeybpRsNoQedWA5zmw8dYAA&e=> 2. The incident field has a change relating to the script name, please use the script name instead of the ID. (screenshot attached) [image: image] <https://urldefense.proofpoint.com/v2/url?u=https-3A__user-2Dimages.githubusercontent.com_28757135_262275351-2Dd16cd7b7-2Da158-2D4a53-2D967b-2D46ae419b2d3b.png&d=DwMCaQ&c=V9IgWpI5PvzTw83UyHGVSoW3Uc1MFWe5J8PTfkrzVSo&r=c4k2lAmoL_NLIKl9qYVpJ-M0mh6RKSaHBNpd5VoXXPE&m=K5yMWx0Fy7gwf5WBwhAEhe7945xj1EJZjk8JVov22kqTe5HbGQL8Ca4-K4JQieS0&s=BkHSLWffH0XEFNNUAeFw_nAcqsgJ__9fk19j0-4_57s&e=> I trust that these suggestions will be valuable in fine-tuning the content. Once again, thank you for your commitment and hard work. I'm confident that with these minor tweaks, we'll be able to deliver an even more polished product to our users. Warm regards, Ben — Reply to this email directly, view it on GitHub <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_demisto_content_pull_28959-23issuecomment-2D1687659494&d=DwMCaQ&c=V9IgWpI5PvzTw83UyHGVSoW3Uc1MFWe5J8PTfkrzVSo&r=c4k2lAmoL_NLIKl9qYVpJ-M0mh6RKSaHBNpd5VoXXPE&m=K5yMWx0Fy7gwf5WBwhAEhe7945xj1EJZjk8JVov22kqTe5HbGQL8Ca4-K4JQieS0&s=H80692j4IJUf4xlKHjwX2-52KO5_UYJwW51Oiz2N1os&e=>, or unsubscribe <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AVTN25SPVFNSA53LQCUS753XWRQMHANCNFSM6AAAAAA3P2ZFPY&d=DwMCaQ&c=V9IgWpI5PvzTw83UyHGVSoW3Uc1MFWe5J8PTfkrzVSo&r=c4k2lAmoL_NLIKl9qYVpJ-M0mh6RKSaHBNpd5VoXXPE&m=K5yMWx0Fy7gwf5WBwhAEhe7945xj1EJZjk8JVov22kqTe5HbGQL8Ca4-K4JQieS0&s=VG43QA5LtaAfbnDg24KnWERVi53hU3qYTaq_2dBguyc&e=> . You are receiving this because you were mentioned.Message ID: ***@***.***>

melamedbn · 2023-08-23T09:17:32Z

@rurhrlaub
Thank you for taking the time to review my feedback. I've updated the env and I see the script names are present.

Best regards,
Ben

rurhrlaub · 2023-08-23T15:37:12Z

No message - it is @randy Uhrlaub in Slack.

…

On Wed, Aug 23, 2023 at 10:21 AM Yehuda Rosenberg ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In Packs/ContentTesting/Scripts/UnitTestCasePrep/UnitTestCasePrep.py <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_demisto_content_pull_28959-23discussion-5Fr1303183403&d=DwMCaQ&c=V9IgWpI5PvzTw83UyHGVSoW3Uc1MFWe5J8PTfkrzVSo&r=c4k2lAmoL_NLIKl9qYVpJ-M0mh6RKSaHBNpd5VoXXPE&m=x2CItrR20dnpN7r5h671EW6RdVI-n7US7_QiE4gdxctFqVIEQMUJnRAxdg5p8IDy&s=Q5h2NCpnns5PFeJ_w_riflu_Z670_OksNyWJxV7flik&e=> : > try: + args = demisto.args() + testName = args.get("testName", "") Hi @rurhrlaub <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_rurhrlaub&d=DwMCaQ&c=V9IgWpI5PvzTw83UyHGVSoW3Uc1MFWe5J8PTfkrzVSo&r=c4k2lAmoL_NLIKl9qYVpJ-M0mh6RKSaHBNpd5VoXXPE&m=x2CItrR20dnpN7r5h671EW6RdVI-n7US7_QiE4gdxctFqVIEQMUJnRAxdg5p8IDy&s=JfVVrM7tnZ4A3W9JvT3ta1kXCwu8Avne4DblTFE84TA&e=>, how are you? I've messaged you via Slack. Is "David Uhrlaub" your username there? I'm currently looking into this unusual problem of lines moving without your touch, and would greatly value your responses. — Reply to this email directly, view it on GitHub <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_demisto_content_pull_28959-23discussion-5Fr1303183403&d=DwMCaQ&c=V9IgWpI5PvzTw83UyHGVSoW3Uc1MFWe5J8PTfkrzVSo&r=c4k2lAmoL_NLIKl9qYVpJ-M0mh6RKSaHBNpd5VoXXPE&m=x2CItrR20dnpN7r5h671EW6RdVI-n7US7_QiE4gdxctFqVIEQMUJnRAxdg5p8IDy&s=Q5h2NCpnns5PFeJ_w_riflu_Z670_OksNyWJxV7flik&e=>, or unsubscribe <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AVTN25QHK27GZXCMBIHGTEDXWYNV3ANCNFSM6AAAAAA3P2ZFPY&d=DwMCaQ&c=V9IgWpI5PvzTw83UyHGVSoW3Uc1MFWe5J8PTfkrzVSo&r=c4k2lAmoL_NLIKl9qYVpJ-M0mh6RKSaHBNpd5VoXXPE&m=x2CItrR20dnpN7r5h671EW6RdVI-n7US7_QiE4gdxctFqVIEQMUJnRAxdg5p8IDy&s=smQv-O3UrdW_zD2uDZdl8YDgdkmugYwljbMMOPwxZlI&e=> . You are receiving this because you were mentioned.Message ID: ***@***.***>

rurhrlaub · 2023-08-23T15:39:25Z

PS - If I look in github, lines are there?? def main(): try: args = demisto.args() testName = args.get("testName", "") listName = args.get("listName", "") if listName != "": listlines = demisto.executeCommand("getList", {'listName': listName})[0]['Contents'] buf = io.StringIO(listlines) else: raise DemistoException("No test case list provided")

…

On Wed, Aug 23, 2023 at 10:21 AM Yehuda Rosenberg ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In Packs/ContentTesting/Scripts/UnitTestCasePrep/UnitTestCasePrep.py <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_demisto_content_pull_28959-23discussion-5Fr1303183403&d=DwMCaQ&c=V9IgWpI5PvzTw83UyHGVSoW3Uc1MFWe5J8PTfkrzVSo&r=c4k2lAmoL_NLIKl9qYVpJ-M0mh6RKSaHBNpd5VoXXPE&m=x2CItrR20dnpN7r5h671EW6RdVI-n7US7_QiE4gdxctFqVIEQMUJnRAxdg5p8IDy&s=Q5h2NCpnns5PFeJ_w_riflu_Z670_OksNyWJxV7flik&e=> : > try: + args = demisto.args() + testName = args.get("testName", "") Hi @rurhrlaub <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_rurhrlaub&d=DwMCaQ&c=V9IgWpI5PvzTw83UyHGVSoW3Uc1MFWe5J8PTfkrzVSo&r=c4k2lAmoL_NLIKl9qYVpJ-M0mh6RKSaHBNpd5VoXXPE&m=x2CItrR20dnpN7r5h671EW6RdVI-n7US7_QiE4gdxctFqVIEQMUJnRAxdg5p8IDy&s=JfVVrM7tnZ4A3W9JvT3ta1kXCwu8Avne4DblTFE84TA&e=>, how are you? I've messaged you via Slack. Is "David Uhrlaub" your username there? I'm currently looking into this unusual problem of lines moving without your touch, and would greatly value your responses. — Reply to this email directly, view it on GitHub <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_demisto_content_pull_28959-23discussion-5Fr1303183403&d=DwMCaQ&c=V9IgWpI5PvzTw83UyHGVSoW3Uc1MFWe5J8PTfkrzVSo&r=c4k2lAmoL_NLIKl9qYVpJ-M0mh6RKSaHBNpd5VoXXPE&m=x2CItrR20dnpN7r5h671EW6RdVI-n7US7_QiE4gdxctFqVIEQMUJnRAxdg5p8IDy&s=Q5h2NCpnns5PFeJ_w_riflu_Z670_OksNyWJxV7flik&e=>, or unsubscribe <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AVTN25QHK27GZXCMBIHGTEDXWYNV3ANCNFSM6AAAAAA3P2ZFPY&d=DwMCaQ&c=V9IgWpI5PvzTw83UyHGVSoW3Uc1MFWe5J8PTfkrzVSo&r=c4k2lAmoL_NLIKl9qYVpJ-M0mh6RKSaHBNpd5VoXXPE&m=x2CItrR20dnpN7r5h671EW6RdVI-n7US7_QiE4gdxctFqVIEQMUJnRAxdg5p8IDy&s=smQv-O3UrdW_zD2uDZdl8YDgdkmugYwljbMMOPwxZlI&e=> . You are receiving this because you were mentioned.Message ID: ***@***.***>

CLAassistant · 2023-08-24T12:30:21Z

All committers have signed the CLA.

…7' into rurhrlaub-contrib-ContentTesting-7

) * [Marketplace Contribution] Content Testing - Content Pack Update (#28959) * "contribution update to pack "Content Testing"" * Update incidentfield-Content_Testing_Unit_Test_Playbooks.json Fixed "script": "UnitTestMultiSelect", * remove the wired changes in the pr * help the build pass * validate * avoiding breaking changes * docker image * docker image --------- Co-authored-by: David Uhrlaub <[email protected]> Co-authored-by: Yehuda <[email protected]> Co-authored-by: Yehuda Rosenberg <[email protected]> * change default * add default value for unrequited argument * RN * fix validate --------- Co-authored-by: xsoar-bot <[email protected]> Co-authored-by: David Uhrlaub <[email protected]> Co-authored-by: Yehuda <[email protected]> Co-authored-by: Yehuda Rosenberg <[email protected]>

…isto#29308) * [Marketplace Contribution] Content Testing - Content Pack Update (demisto#28959) * "contribution update to pack "Content Testing"" * Update incidentfield-Content_Testing_Unit_Test_Playbooks.json Fixed "script": "UnitTestMultiSelect", * remove the wired changes in the pr * help the build pass * validate * avoiding breaking changes * docker image * docker image --------- Co-authored-by: David Uhrlaub <[email protected]> Co-authored-by: Yehuda <[email protected]> Co-authored-by: Yehuda Rosenberg <[email protected]> * change default * add default value for unrequited argument * RN * fix validate --------- Co-authored-by: xsoar-bot <[email protected]> Co-authored-by: David Uhrlaub <[email protected]> Co-authored-by: Yehuda <[email protected]> Co-authored-by: Yehuda Rosenberg <[email protected]>

"contribution update to pack "Content Testing""

f5cf7ce

content-bot added Contribution Thank you! Contributions are always welcome! External PR Community Support Level Indicates that the contribution is for Community supported pack labels Aug 14, 2023

content-bot changed the base branch from master to contrib/xsoar-contrib_rurhrlaub-contrib-ContentTesting-7 August 14, 2023 15:15

content-bot assigned RosenbergYehuda and melamedbn Aug 14, 2023

content-bot added the Security Review label Aug 14, 2023

content-bot requested review from melamedbn and RosenbergYehuda August 14, 2023 15:15

RosenbergYehuda reviewed Aug 20, 2023

View reviewed changes

Update incidentfield-Content_Testing_Unit_Test_Playbooks.json

e87b434

Fixed "script": "UnitTestMultiSelect",

melamedbn approved these changes Aug 23, 2023

View reviewed changes

remove the wired changes in the pr

68735b9

RosenbergYehuda and others added 2 commits August 24, 2023 15:31

Merge branch 'contrib/xsoar-contrib_rurhrlaub-contrib-ContentTesting-…

fe085a4

…7' into rurhrlaub-contrib-ContentTesting-7

help the build pass

8d9c0b1

RosenbergYehuda approved these changes Aug 24, 2023

View reviewed changes

validate

f7eb5bd

RosenbergYehuda added the post-demo label Aug 28, 2023

avoiding breaking changes

0fbbe42

RosenbergYehuda added the docs-approved label Aug 29, 2023

RosenbergYehuda added 2 commits August 29, 2023 12:10

Merge branch 'contrib/xsoar-contrib_rurhrlaub-contrib-ContentTesting-…

7e00c34

…7' into rurhrlaub-contrib-ContentTesting-7

Merge branch 'contrib/xsoar-contrib_rurhrlaub-contrib-ContentTesting-…

eccce67

…7' into rurhrlaub-contrib-ContentTesting-7

RosenbergYehuda added 2 commits August 29, 2023 12:25

docker image

308cb6c

docker image

b81c5e8

RosenbergYehuda merged commit 6cb2787 into demisto:contrib/xsoar-contrib_rurhrlaub-contrib-ContentTesting-7 Aug 29, 2023

content-bot mentioned this pull request Aug 29, 2023

[Marketplace Contribution] Content Testing - Content Pack Update #29308

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Marketplace Contribution] Content Testing - Content Pack Update #28959

[Marketplace Contribution] Content Testing - Content Pack Update #28959

xsoar-bot commented Aug 14, 2023

content-bot commented Aug 14, 2023

RosenbergYehuda left a comment

RosenbergYehuda Aug 20, 2023

rurhrlaub Aug 21, 2023

RosenbergYehuda Aug 21, 2023

RosenbergYehuda Aug 23, 2023

RosenbergYehuda Aug 20, 2023

rurhrlaub Aug 21, 2023

RosenbergYehuda Aug 20, 2023

rurhrlaub Aug 21, 2023

RosenbergYehuda Aug 20, 2023

RosenbergYehuda Aug 20, 2023

RosenbergYehuda Aug 20, 2023

RosenbergYehuda Aug 20, 2023

melamedbn commented Aug 22, 2023

rurhrlaub commented Aug 22, 2023 via email

melamedbn commented Aug 23, 2023 •

edited

Loading

rurhrlaub commented Aug 23, 2023 via email

rurhrlaub commented Aug 23, 2023 via email

CLAassistant commented Aug 24, 2023 •

edited

Loading

[Marketplace Contribution] Content Testing - Content Pack Update #28959

[Marketplace Contribution] Content Testing - Content Pack Update #28959

Conversation

xsoar-bot commented Aug 14, 2023

Status

Contributor

Notes

Video Link

content-bot commented Aug 14, 2023

RosenbergYehuda left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

melamedbn commented Aug 22, 2023

Misconfigurations

rurhrlaub commented Aug 22, 2023 via email

melamedbn commented Aug 23, 2023 • edited Loading

rurhrlaub commented Aug 23, 2023 via email

rurhrlaub commented Aug 23, 2023 via email

CLAassistant commented Aug 24, 2023 • edited Loading

melamedbn commented Aug 23, 2023 •

edited

Loading

CLAassistant commented Aug 24, 2023 •

edited

Loading