Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align Creds for PaloAltoNetworksIoT3rdParty, ImpervaSkyfence, FireEyeHelix, HPEArubaClearPass #27559

Merged
merged 19 commits into from
Jun 25, 2023
Merged
Show file tree
Hide file tree
Changes from 18 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Packs/FireEyeHelix/.pack-ignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[file:FireEyeHelix.yml]
ignore=IN126,IN145
ignore=IN126

[file:README.md]
ignore=RM104,RM106
ignore=RM104,RM106
4 changes: 2 additions & 2 deletions Packs/FireEyeHelix/Integrations/FireEyeHelix/FireEyeHelix.py
Original file line number Diff line number Diff line change
Expand Up @@ -1704,12 +1704,12 @@ def main(): # pragma: no cover
base_url = f"{params.get('url', '').rstrip('/')}"
if not base_url.endswith('/helix/id'):
base_url += '/helix/id'
base_url += f"/{params.get('h_id')}"
base_url += f"/{params.get('h_id_creds', {}).get('identifier') or params.get('h_id')}"
verify_ssl = not params.get('insecure', False)
proxy = params.get('proxy')
headers = {
'accept': 'application/json',
'x-fireeye-api-key': params.get('token')
'x-fireeye-api-key': params.get('h_id_creds', {}).get('password') or params.get('token')
}
client = Client(base_url=base_url, verify=verify_ssl, proxy=proxy, headers=headers)
command = demisto.command()
Expand Down
25 changes: 17 additions & 8 deletions Packs/FireEyeHelix/Integrations/FireEyeHelix/FireEyeHelix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,20 +15,28 @@ configuration:
section: Connect
- display: Customer ID
name: h_id
required: true
required: false
type: 0
section: Connect
hidden: true
- display: API Token
name: token
required: true
required: false
type: 4
section: Connect
- defaultvalue: 3 days
display: First fetch timestamp (<number> <time unit>, e.g., 12 hours, 7 days, 3 months, 1 year)
hidden: true
- display: Customer ID
name: h_id_creds
required: false
type: 9
section: Connect
displaypassword: API Token
- display: First fetch timestamp (<number> <time unit>, e.g., 12 hours, 7 days, 3 months, 1 year)
name: fetch_time
required: false
type: 0
section: Collect
defaultvalue: 3 days
- display: Fetch incidents
name: isFetch
required: false
Expand All @@ -45,12 +53,13 @@ configuration:
type: 8
section: Connect
advanced: true
- display: Use system proxy settings
- advanced: true
display: Use system proxy settings
name: proxy
required: false
type: 8
section: Connect
advanced: true
type: 8

description: FireEye Helix is a security operations platform. FireEye Helix integrates security tools and augments them with next-generation SIEM, orchestration and threat intelligence tools such as alert management, search, analysis, investigations and reporting.
display: FireEye Helix
name: FireEyeHelix
Expand Down Expand Up @@ -2037,7 +2046,7 @@ script:
- contextPath: FireEyeHelixSearch.State
description: State of the search.
type: String
dockerimage: demisto/python3:3.10.8.37233
dockerimage: demisto/python3:3.10.12.63474
isfetch: true
longRunning: false
longRunningPort: false
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
In order to configure this integration you will a FireEye customer ID. Your customer ID is used in your FireEye Helix available in the URL of your FireEye Helix app after */helix/id/*. e.g. for the following URL *https://apps.fireeye.com/helix/id/**helixid*** the customer ID is helixid.

The API key can be found and generated in the API KEYS section. You can navigate to it from your FireEye Helix app home page by clicking on the user icon on the top right, and choosing HELIX Settings. You'll be redirected to the HELIX Settings page, where API KEYS can be found.
The API key can be found and generated in the API KEYS section. You can navigate to it from your FireEye Helix app home page by clicking on the user icon on the top right, and choosing HELIX Settings. You'll be redirected to the HELIX Settings page, where API KEYS can be found.
9 changes: 9 additions & 0 deletions Packs/FireEyeHelix/ReleaseNotes/1_0_8.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@

#### Integrations

##### FireEye Helix

- You can now use credentials when configuring the following fields:
- *Customer ID*
- *API Token*
- Updated the Docker image to: *demisto/python3:3.10.12.63474*.
2 changes: 1 addition & 1 deletion Packs/FireEyeHelix/pack_metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "FireEye Helix",
"description": "FireEye Helix is a security operations platform. FireEye Helix integrates security tools and augments them with next-generation SIEM, orchestration and threat intelligence tools such as alert management, search, analysis, investigations and reporting.",
"support": "xsoar",
"currentVersion": "1.0.7",
"currentVersion": "1.0.8",
"author": "Cortex XSOAR",
"url": "https://www.paloaltonetworks.com/cortex",
"email": "",
Expand Down
3 changes: 0 additions & 3 deletions Packs/HPEArubaClearPass/.pack-ignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
[file:HPEArubaClearPass.yml]
ignore=IN145

[known_words]
HPE
ClearPass
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -421,8 +421,8 @@ def disconnect_active_session_command(client: Client, args: Dict[str, Any]) -> C
def main() -> None:
params = demisto.params()
base_url = urljoin(params.get('url'), '/api')
client_id = params.get('client_id')
client_secret = params.get('client_secret')
client_id = params.get('client_id_creds', {}).get('identifier') or params.get('client_id')
client_secret = params.get('client_id_creds', {}).get('password') or params.get('client_secret')
verify_certificate = not params.get('insecure', False)
proxy = params.get('proxy', False)

Expand Down
Loading