Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align Creds for PaloAltoNetworksIoT3rdParty, ImpervaSkyfence, FireEyeHelix, HPEArubaClearPass #27559

Merged
merged 19 commits into from
Jun 25, 2023

Conversation

jlevypaloalto
Copy link
Contributor

@jlevypaloalto jlevypaloalto commented Jun 19, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: Align Credentials for PaloAltoNetworksIoT3rdParty, ImpervaSkyfence, FireEyeHelix, HPEArubaClearPass

Description

Align Creds for:

  • PaloAltoNetworksIoT3rdParty
  • ImpervaSkyfence
  • FireEyeHelix
  • HPEArubaClearPass

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@jlevypaloalto jlevypaloalto removed the request for review from daryakoval June 20, 2023 10:48
@jlevypaloalto jlevypaloalto added the ForceMerge Forcing the merge of the PR despite the build status label Jun 20, 2023
@jlevypaloalto
Copy link
Contributor Author

This PR must be force-merged as both PaloAltoNetworksIoT3rdParty and ImpervaSkyfence have no unit-tests

Copy link
Contributor

@JudahSchwartz JudahSchwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note my comment, otherwise looks great

@ShahafBenYakir ShahafBenYakir merged commit c1db9f7 into master Jun 25, 2023
@ShahafBenYakir ShahafBenYakir deleted the jl-align-creds-4 branch June 25, 2023 08:47
MosheEichler pushed a commit that referenced this pull request Jul 2, 2023
…Helix, HPEArubaClearPass (#27559)

* PaloAltoNetworksIoT3rdParty complete

* ImpervaSkyfence complete

* FireEyeHelix complete

* HPEArubaClearPass complete

* HPEArubaClearPass complete

* fixed pack-ignores

* removed readmes

* fixed fireeyehelix

* added ignored words

* added readme to ImpervaSkyfence

* removed readme

* Update on-push.yml

* Revert "removed readme"

This reverts commit 9250202.

* added version to readme

* IS now should work

* PANIOT3P: creds now for key fields

* PANIOT3P: un-hid customer id

* debug for try-continue
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Jul 26, 2023
…Helix, HPEArubaClearPass (demisto#27559)

* PaloAltoNetworksIoT3rdParty complete

* ImpervaSkyfence complete

* FireEyeHelix complete

* HPEArubaClearPass complete

* HPEArubaClearPass complete

* fixed pack-ignores

* removed readmes

* fixed fireeyehelix

* added ignored words

* added readme to ImpervaSkyfence

* removed readme

* Update on-push.yml

* Revert "removed readme"

This reverts commit 9250202.

* added version to readme

* IS now should work

* PANIOT3P: creds now for key fields

* PANIOT3P: un-hid customer id

* debug for try-continue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ForceMerge Forcing the merge of the PR despite the build status
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants