Penfield AI Pull Request 2 #15523

penfield-chan · 2021-10-27T17:01:21Z

Followup to: #15074

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

In Progress
Ready
In Hold - (Reason for hold)

Related Issues

11 issues were mentioned in the last PR. All should be addressed here. Unclear why test failed in remote environment, may need updated results for CircleCI to determine why.

Description

Resolve the 11 identified issues, perform some other supporting changes.

Screenshots

Paste here any images that will help the reviewer

Minimum version of Cortex XSOAR

[X ] 6.0.0
6.1.0
6.2.0
6.5.0

Does it break backward compatibility?

Yes
- Further details:
[X ] No

Must have

[ X] Tests
[X ] Documentation

content-bot · 2021-10-27T17:03:09Z

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @ShacharKidor will know he can start review the proposed changes.

Packs/PenfieldAI/Integrations/Penfield/Penfield.py

daryakoval · 2021-10-28T09:29:25Z

Packs/PenfieldAI/Integrations/Penfield/Penfield.py

+
+        if demisto.command() == 'test-module':
+            result = test_api(client)
+            if result == 'healthy':


The API response can be healthy ?

I've converted it a more standard 0=healthy and 1=error

Packs/PenfieldAI/Integrations/Penfield/Penfield.py

daryakoval · 2021-10-28T09:32:04Z

Packs/PenfieldAI/Scripts/PenfieldAssign/PenfieldAssign.py

+
+        # get online analyst ids
+        analysts = demisto.executeCommand('getUsers', {'online': True})[0]['Contents']
+        analyst_ids = []


Is analyst_id supposed to be array? or comma-seperated string?

It is supposed to be an array of strings.

penfield-chan · 2021-11-02T16:44:48Z

I have added my code changes which should address the questions. Let me know if you spot anything amiss.

Thanks.

daryakoval · 2021-11-03T06:36:04Z

@penfield-chan Hi, let’s schedule a demo call.

content-bot · 2021-11-08T16:30:11Z

This PR is starting to get a little stale. @penfield-chan are there any changes you wanted to make since @daryakoval's last comment?

daryakoval · 2021-11-09T11:51:38Z

Re-scheduled demo for next week.

content-bot · 2021-11-14T17:30:15Z

This PR is starting to get a little stale. @penfield-chan are there any changes you wanted to make since @daryakoval's last comment?

daryakoval · 2021-11-16T15:23:18Z

Hi, we have couple comments from demo:

Consider to add playbook instead or in addition to script.
Change input for argument analyst_ids from string array to comma separated, for example: admin,darya,penfield. You can use argToList function from CommonServerPython module to change comma-seperated string to list.

daryakoval · 2021-11-16T15:24:17Z

Packs/PenfieldAI/Integrations/Penfield/Penfield.py

+
+
+def get_assignee(client: Client, args) -> CommandResults:
+    analyst_ids = args.get('analyst_ids')


Suggested change

analyst_ids = args.get('analyst_ids')

analyst_ids = argToList(args.get('analyst_ids'))

content-bot · 2021-11-21T17:30:16Z

This PR is starting to get a little stale. @penfield-chan are there any changes you wanted to make since @daryakoval's last comment?

PR review updates: 1) update analyst_ids argument to use comma-separated values in a string instead of list. 2) add basic Penfield Assign playbook

CLAassistant · 2021-11-26T01:08:26Z

All committers have signed the CLA.

L-Tan · 2021-11-26T01:41:39Z

@daryakoval sorry for the delayed update on this PR. Two main changes are introduced after the demo:

Use comma-separated list for the arg
Add a simple Penfield Assign playbook

Could you please take another look? Thanks a lot.

Packs/PenfieldAI/Playbooks/Penfield_Assign.yml

Update fromversion to 6.0.0 Co-authored-by: Darya Koval <[email protected]>

* Penfield AI Pull Request 2 (#15523) * penfield init * issue 1: remove unowned files from pack-ignore * address pull request issues * address pull request issues 2 * remove code comment * udpate command results * change healthy response code * xflake and unittest work * Update penfield content pack metadata with company info * Update to use string as analyst_ids arg * Add Penfield Assign playbook * Add playbook README with the playbook image (#2) * use argToList helper instead of split * Update Packs/PenfieldAI/Playbooks/Penfield_Assign.yml Update fromversion to 6.0.0 Co-authored-by: Darya Koval <[email protected]> Co-authored-by: the-naturel <[email protected]> Co-authored-by: Long <[email protected]> Co-authored-by: Long Tan <[email protected]> Co-authored-by: Darya Koval <[email protected]> * formatting files Co-authored-by: penfield-chan <[email protected]> Co-authored-by: the-naturel <[email protected]> Co-authored-by: Long <[email protected]> Co-authored-by: Long Tan <[email protected]> Co-authored-by: Darya Koval <[email protected]> Co-authored-by: Darya Koval <[email protected]>

penfield-chan and others added 6 commits September 28, 2021 18:39

penfield init

5271af0

Merge branch 'demisto:master' into master

5ef9a19

issue 1: remove unowned files from pack-ignore

e5e032c

address pull request issues

beb6492

address pull request issues 2

c5eb2a2

Merge branch 'demisto:master' into master

3423919

content-bot added the Contribution Thank you! Contributions are always welcome! label Oct 27, 2021

content-bot changed the base branch from master to contrib/penfield-chan_master October 27, 2021 17:02

content-bot assigned ShacharKidor Oct 27, 2021

content-bot requested a review from ShacharKidor October 27, 2021 17:03

daryakoval requested review from daryakoval and removed request for ShacharKidor October 28, 2021 08:58

daryakoval assigned daryakoval and unassigned ShacharKidor Oct 28, 2021

daryakoval requested changes Oct 28, 2021

View reviewed changes

daryakoval added Partner Contribution Form Filled Whether contribution form filled or not. labels Oct 28, 2021

edik24 mentioned this pull request Oct 31, 2021

Penfield AI Pull Request 1 #15074

Closed

11 tasks

penfield-chan added 4 commits November 2, 2021 12:03

remove code comment

203bbe2

udpate command results

94cfb3c

change healthy response code

a222d40

xflake and unittest work

0c09296

daryakoval reviewed Nov 16, 2021

View reviewed changes

L-Tan and others added 4 commits November 23, 2021 13:39

Update penfield content pack metadata with company info

54e9e78

Update to use string as analyst_ids arg

833d421

Add Penfield Assign playbook

23b8c7c

Update argument type and add playbook - Penfield content pack

21bd874

PR review updates: 1) update analyst_ids argument to use comma-separated values in a string instead of list. 2) add basic Penfield Assign playbook

L-Tan added 2 commits November 25, 2021 20:29

Add playbook README with the playbook image (#2)

b51e63f

use argToList helper instead of split

aa79efe

daryakoval reviewed Nov 29, 2021

View reviewed changes

Packs/PenfieldAI/Playbooks/Penfield_Assign.yml Outdated Show resolved Hide resolved

Update Packs/PenfieldAI/Playbooks/Penfield_Assign.yml

dab2aa1

Update fromversion to 6.0.0 Co-authored-by: Darya Koval <[email protected]>

daryakoval approved these changes Nov 30, 2021

View reviewed changes

daryakoval added the docs-approved label Nov 30, 2021

daryakoval merged commit 354e1a4 into demisto:contrib/penfield-chan_master Nov 30, 2021

content-bot mentioned this pull request Nov 30, 2021

Penfield AI Pull Request 2 #16028

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Penfield AI Pull Request 2 #15523

Penfield AI Pull Request 2 #15523

penfield-chan commented Oct 27, 2021

content-bot commented Oct 27, 2021

daryakoval Oct 28, 2021

penfield-chan Nov 2, 2021

daryakoval Oct 28, 2021

penfield-chan Nov 2, 2021

penfield-chan commented Nov 2, 2021

daryakoval commented Nov 3, 2021

content-bot commented Nov 8, 2021

daryakoval commented Nov 9, 2021

content-bot commented Nov 14, 2021

daryakoval commented Nov 16, 2021

daryakoval Nov 16, 2021

content-bot commented Nov 21, 2021

CLAassistant commented Nov 26, 2021 •

edited

Loading

L-Tan commented Nov 26, 2021



		def get_assignee(client: Client, args) -> CommandResults:
		analyst_ids = args.get('analyst_ids')

	analyst_ids = args.get('analyst_ids')
	analyst_ids = argToList(args.get('analyst_ids'))

Penfield AI Pull Request 2 #15523

Penfield AI Pull Request 2 #15523

Conversation

penfield-chan commented Oct 27, 2021

Contributing to Cortex XSOAR Content

Status

Related Issues

Description

Screenshots

Minimum version of Cortex XSOAR

Does it break backward compatibility?

Must have

content-bot commented Oct 27, 2021

daryakoval Oct 28, 2021

Choose a reason for hiding this comment

penfield-chan Nov 2, 2021

Choose a reason for hiding this comment

daryakoval Oct 28, 2021

Choose a reason for hiding this comment

penfield-chan Nov 2, 2021

Choose a reason for hiding this comment

penfield-chan commented Nov 2, 2021

daryakoval commented Nov 3, 2021

content-bot commented Nov 8, 2021

daryakoval commented Nov 9, 2021

content-bot commented Nov 14, 2021

daryakoval commented Nov 16, 2021

daryakoval Nov 16, 2021

Choose a reason for hiding this comment

content-bot commented Nov 21, 2021

CLAassistant commented Nov 26, 2021 • edited Loading

L-Tan commented Nov 26, 2021

CLAassistant commented Nov 26, 2021 •

edited

Loading