Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Penfield AI Pull Request 1 #15074

Closed

Conversation

penfield-chan
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Screenshots

Paste here any images that will help the reviewer

Minimum version of Cortex XSOAR

  • 5.5.0
  • 6.0.0
  • 6.1.0
  • 6.2.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@CLAassistant
Copy link

CLAassistant commented Sep 28, 2021

CLA assistant check
All committers have signed the CLA.

@content-bot content-bot added the Contribution Thank you! Contributions are always welcome! label Sep 28, 2021
@content-bot content-bot changed the base branch from master to contrib/the-naturel_master September 28, 2021 22:43
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @barchen1 will know he can start review the proposed changes.

@guykeller
Copy link
Contributor

Hi there!
Due to a sequence of holidays in recent weeks, your review was delayed. We apologize for the inconvenience and will try to do our best to complete your review as quickly and efficiently as possible, please bear with us.
Thanks for your understanding, and for your contribution.

1 similar comment
@guykeller
Copy link
Contributor

Hi there!
Due to a sequence of holidays in recent weeks, your review was delayed. We apologize for the inconvenience and will try to do our best to complete your review as quickly and efficiently as possible, please bear with us.
Thanks for your understanding, and for your contribution.

@daryakoval
Copy link
Contributor

Hi, Please register your contribution by filling the Contribution Registration form.

Packs/PenfieldAI/.pack-ignore Show resolved Hide resolved

# get online analyst ids
analysts = demisto.executeCommand('getUsers', {'online': True})[0]['Contents']
analyst_ids = []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is analyst_id supposed to be array? or comma-seperated string?

type: python
subtype: python3
dockerimage: demisto/python3:3.9.7.24076
fromversion: 5.5.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is no special reason to make this script version 5.5.0, please change to 6.0.0

Suggested change
fromversion: 5.5.0
fromversion: 6.0.0

fromversion: 5.5.0
dependson:
must:
- Penfield|||PenfieldGetAssignee
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Penfield|||PenfieldGetAssignee
- Penfield|||penfield-get-assignee

---
!PenfieldAssign
!PenfieldAssign assign='Yes'
!PenfieldAssign assign='No'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add Human Readable Output example, and command run example. You can generate it automatically using generate-docs sdk command. More info about README.


## Examples
---
!penfield-api-call analyst_ids=['analystid1', 'analystid2'] category='my cat' created='2021-09-13T01:58:22.621033322Z' id=34 name='big rootkit attack' severity='High'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

command example should be !penfield-get-assignee ...
Please add Human Readable Output example, and command run example. You can generate it automatically using generate-docs sdk command.
More info about README.

@daryakoval
Copy link
Contributor

@penfield-chan Hi, Please register your contribution by filling the Contribution Registration form.

@ShahafBenYakir
Copy link
Contributor

FYI @edik24

@content-bot content-bot added Contribution Form Filled Whether contribution form filled or not. Partner labels Oct 11, 2021
@content-bot
Copy link
Collaborator

This PR is starting to get a little stale. @penfield-chan are there any changes you wanted to make since @ShahafBenYakir's last comment?

@penfield-chan penfield-chan mentioned this pull request Oct 27, 2021
7 tasks
@edik24
Copy link
Contributor

edik24 commented Oct 31, 2021

New PR was opened
#15523

this one is closed

@edik24 edik24 closed this Oct 31, 2021
@content-bot content-bot mentioned this pull request Nov 30, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants