Fix stickers dropped pasted and picked from gallery #2535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amzd
commented
Jan 18, 2025
r10s
reviewed
Jan 21, 2025
r10s
approved these changes
Jan 21, 2025
Co-authored-by: bjoern <[email protected]>
This was referenced Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the transparency logic from #2258 and sends image as sticker when they come from anywhere, not just pasted.
Also prioritize webP data in dropped items to prevent transparency loss when webP and JPEG are provided by drag and drop.
That PR mentioned dropping was unreliable which I think happened because sometimes the drop provides a webP which was not supported at all previously.
It also mentioned a sometimes black background which was either the system providing both JPEG and webP and Delta Chat choosing JPEG which does not have transparency OR the dropped image was too big core resized it and lost transparency (deltachat/deltachat-core-rust#6447).