revert #3177 #3365
Merged
revert #3177 #3365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
did not look in detail about the impact (will do tomorrow) but in any case, we should not remove the strings but deprecate them, otherwise other os will get in trouble, we shoudl give them time to adapt |
|
To test the changes in this pull request, install this apk: |
|
To test the changes in this pull request, install this apk: |
r10s
approved these changes
Oct 18, 2024
|
closing stale PR |
adbenitez
force-pushed
the
adb/issue-3361
branch
from
b3e1e01 to
6aed8d0
Compare
|
To test the changes in this pull request, install this apk: |
Hocuri
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3361