Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent creating contact without encryption in chatmail account #3177

Merged
merged 6 commits into from
Jul 30, 2024

Conversation

adbenitez
Copy link
Member

close #3162

@adbenitez adbenitez requested a review from r10s July 19, 2024 19:15
@adbenitez adbenitez self-assigned this Jul 19, 2024
@@ -917,6 +917,7 @@
<string name="chat_protection_broken_explanation">End-to-end encryption cannot be guaranteed anymore, likely because %1$s reinstalled Delta Chat or sent a message from another device.\n\nYou may meet them in person and scan their QR code again to reestablish guaranteed end-to-end encryption.</string>
<string name="invalid_unencrypted_tap_to_learn_more">⚠️ %1$s requires end-to-end encryption which is not setup for this chat yet. Tap to learn more.</string>
<string name="invalid_unencrypted_explanation">To establish end-to-end-encryption, you may meet contacts in person and scan their QR Code to introduce them.</string>
<string name="encryption_required_for_new_contact">End-to-end encryption is required but it is not setup for %1$s yet.\n\nYou may share your invite link with them or meet in person and scan their QR Code.</string>
Copy link
Member Author

@adbenitez adbenitez Jul 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to tweak the message

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/fill free/feel free/ - tweaked :)

Copy link

To test the changes in this pull request, install this apk:
📦 app-preview.apk

Copy link

To test the changes in this pull request, install this apk:
📦 app-preview.apk

Copy link
Member

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did a quick test by adding sth. as send [email protected] a mail to "Saved messages" on chatmail-profile - the message is tappable, but then just nothing happens. for non-chatmail-profile, the old "chat with ...?" is shown (emulator, android14)

apart from that, the gist of the PR makes sense to me :)

@adbenitez
Copy link
Member Author

did a quick test by adding sth. as send [email protected] a mail to "Saved messages" on chatmail-profile - the message is tappable, but then just nothing happens. for non-chatmail-profile, the old "chat with ...?" is shown (emulator, android14)

fixed it

Copy link

To test the changes in this pull request, install this apk:
📦 app-preview.apk

Copy link

To test the changes in this pull request, install this apk:
📦 app-preview.apk

Copy link

To test the changes in this pull request, install this apk:
📦 app-preview.apk

@adbenitez adbenitez merged commit 8e802e1 into main Jul 30, 2024
2 checks passed
@adbenitez adbenitez deleted the adb/issue-3162 branch July 30, 2024 13:18
adbenitez added a commit that referenced this pull request Oct 14, 2024
adbenitez added a commit that referenced this pull request Jan 18, 2025
adbenitez added a commit that referenced this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Don't offer to chat when clicking an email address
3 participants