-
-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prevent creating contact without encryption in chatmail account #3177
Conversation
@@ -917,6 +917,7 @@ | |||
<string name="chat_protection_broken_explanation">End-to-end encryption cannot be guaranteed anymore, likely because %1$s reinstalled Delta Chat or sent a message from another device.\n\nYou may meet them in person and scan their QR code again to reestablish guaranteed end-to-end encryption.</string> | |||
<string name="invalid_unencrypted_tap_to_learn_more">⚠️ %1$s requires end-to-end encryption which is not setup for this chat yet. Tap to learn more.</string> | |||
<string name="invalid_unencrypted_explanation">To establish end-to-end-encryption, you may meet contacts in person and scan their QR Code to introduce them.</string> | |||
<string name="encryption_required_for_new_contact">End-to-end encryption is required but it is not setup for %1$s yet.\n\nYou may share your invite link with them or meet in person and scan their QR Code.</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feel free to tweak the message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/fill free/feel free/ - tweaked :)
To test the changes in this pull request, install this apk: |
To test the changes in this pull request, install this apk: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did a quick test by adding sth. as send [email protected] a mail
to "Saved messages" on chatmail-profile - the message is tappable, but then just nothing happens. for non-chatmail-profile, the old "chat with ...?" is shown (emulator, android14)
apart from that, the gist of the PR makes sense to me :)
fixed it |
To test the changes in this pull request, install this apk: |
To test the changes in this pull request, install this apk: |
src/main/java/org/thoughtcrime/securesms/ConversationListActivity.java
Outdated
Show resolved
Hide resolved
To test the changes in this pull request, install this apk: |
close #3162