Update GO to 1.19 and format code #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baoy1
force-pushed
the
feature-update-go-1.19
branch
from
2226132 to
404fff8
Compare
baoy1
requested review from
gallacher,
tdawe,
alikdell,
atye,
hoppea2,
coulof,
shaynafinocchiaro,
sharmilarama,
forrestxia,
YianZong,
taohe1012 and
P-Cao
as code owners
|
run e2e test |
forrestxia
previously approved these changes
Oct 11, 2022
|
allowedlist.yaml is temporarily added to address vulnerability CVE-2022-27664. |
baoy1
force-pushed
the
feature-update-go-1.19
branch
from
404fff8 to
1ae28da
Compare
|
run e2e test |
forrestxia
previously approved these changes
Oct 12, 2022
gallacher
previously approved these changes
Oct 12, 2022
taohe1012
previously approved these changes
Oct 13, 2022
baoy1
dismissed stale reviews from taohe1012, gallacher, and forrestxia
via
ac70bc0
|
run e2e test |
taohe1012
previously approved these changes
Oct 16, 2022
forrestxia
previously approved these changes
Oct 17, 2022
YianZong
reviewed
Oct 17, 2022
|
|
||
| server := &http.Server{ | ||
| Addr: addr, | ||
| ReadHeaderTimeout: 5 * time.Second, |
There was a problem hiding this comment.
- Is 'ReadHeaderTimeout' only for TLS listener, or for all Read operation?
- Is 5sec a recommended timeout value?
- Better to use a constant variable for the time out setting.
There was a problem hiding this comment.
ReadHeaderTimeoutis for the newserverinstance, and the instance is for TLS listener. It could say 'ReadHeaderTimeout' only for TLS listener- There is no recommended value. But [PowerStore ]('ReadHeaderTimeout' only for TLS listener) uses 5 the same.
- I flip through all the source code including CSM, 3rd, GO package, timeout values are all set as plain value, not constant. I think it should be good for us as well.
YianZong
previously approved these changes
Oct 17, 2022
gallacher
previously approved these changes
Oct 17, 2022
- Fix CVE-2022-27664 by updating GO to 1.19 and updating golang.org/x/net, golang.org/x/text to the latest - Fix Go Security check alert `Use of net/http serve function that has no support for setting timeouts` Use `server.Serve(tlsListener)` instead of `http.ListenAndServeTLS` - Format code to align with Go format rule
baoy1
dismissed stale reviews from gallacher, YianZong, forrestxia, and taohe1012
via
eb27e9f
baoy1
force-pushed
the
feature-update-go-1.19
branch
from
ac70bc0 to
eb27e9f
Compare
|
run e2e test |
|
|
forrestxia
approved these changes
Oct 18, 2022
1 task
P-Cao
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use of net/http serve function that has no support for setting timeoutsGitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Run make check test
Grafana GUI check
Manual inspection of the GUI
I have verified that the dashboards show the data properly while generating I/O and storage resources