Skip to content

Commit

Permalink
Update GO to 1.19 and format code
Browse files Browse the repository at this point in the history
  • Loading branch information
baoy1 committed Oct 11, 2022
1 parent 06da091 commit 404fff8
Show file tree
Hide file tree
Showing 6 changed files with 17 additions and 3 deletions.
11 changes: 11 additions & 0 deletions .github/containerscan/allowedlist.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
general:
vulnerabilities:
# list of CVEs that are currently unfixed
- CVE-2022-27664
bestPracticeViolations:
# list of best practies violatied that needs a fix
- CIS-DI-0001
- DKL-DI-0006
- CIS-DI-0005
- CIS-DI-0006

4 changes: 2 additions & 2 deletions .github/workflows/actions.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,10 @@ jobs:
name: Image Scanner
runs-on: ubuntu-latest
steps:
- name: Set up Go 1.18+
- name: Set up Go 1.19+
uses: actions/setup-go@v2
with:
go-version: ^1.18
go-version: ^1.19
id: go
- name: Checkout the code
uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/dell/karavi-topology

go 1.18
go 1.19

require (
github.com/fsnotify/fsnotify v1.5.1
Expand Down
1 change: 1 addition & 0 deletions internal/entrypoint/run.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import (
)

// ServiceRunner is an interface of a service that can be run
//
//go:generate mockgen -destination=mocks/service_runner_mocks.go -package=mocks github.com/dell/karavi-topology/internal/entrypoint ServiceRunner
type ServiceRunner interface {
Run() error
Expand Down
1 change: 1 addition & 0 deletions internal/k8s/volume_finder.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ const (
)

// VolumeGetter is an interface for getting a list of persistent volume information
//
//go:generate mockgen -destination=mocks/volume_getter_mocks.go -package=mocks github.com/dell/karavi-topology/internal/k8s VolumeGetter
type VolumeGetter interface {
GetPersistentVolumes() (*corev1.PersistentVolumeList, error)
Expand Down
1 change: 1 addition & 0 deletions internal/service/service.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ type Service struct {
}

// VolumeInfoGetter is an interface used to get a list of volume information
//
//go:generate mockgen -destination=mocks/volume_info_getter_mocks.go -package=mocks github.com/dell/karavi-topology/internal/service VolumeInfoGetter
type VolumeInfoGetter interface {
GetPersistentVolumes(ctx context.Context) ([]k8s.VolumeInfo, error)
Expand Down

0 comments on commit 404fff8

Please sign in to comment.