Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize columns in the topology dashboard #118

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Reorganize columns in the topology dashboard #118

merged 1 commit into from
Aug 3, 2022

Conversation

YianZong
Copy link
Contributor

@YianZong YianZong commented Aug 1, 2022 •
edited by baoy1
Loading

Description

  1. Reorganize columns in the topology table:
    - The order of columns would be :
    Namespace > PVC > PV > StorageClass > Size > Status > Created > Storage System > Protocol > Pool > Volume
    - "not expand" the CSI Driver
  2. Change the external IP into internal one for security check
  3. Update CodeOwner
  4. Update action.yaml for image scanning check

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#453

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have inspected the Grafana dashboards to verify the data is displayed properly
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • UT
    image

  • Manual
    image

Manual inspection of the GUI

I have verified that the dashboards show the data properly while generating I/O and storage resources

  • Yes
  • No

@YianZong YianZong force-pushed the feature-401-ReorgColumns branch from 1e0a20b to 0006943 Compare August 1, 2022 05:28
@YianZong YianZong force-pushed the feature-401-ReorgColumns branch 3 times, most recently from 8d971b5 to 5816c52 Compare August 1, 2022 05:44
@YianZong
Copy link
Contributor Author

YianZong commented Aug 1, 2022

run e2e test

1 similar comment
@YianZong
Copy link
Contributor Author

YianZong commented Aug 1, 2022

run e2e test

@YianZong
Copy link
Contributor Author

YianZong commented Aug 1, 2022

e2e pass

@YianZong
Copy link
Contributor Author

YianZong commented Aug 1, 2022

Hi Code Owners,

Please kindly help review this PR.
The e2e test job is successful: https://osj-sio-03-prd.cec.lab.emc.com/view/CSI-CSM-Consolidation/job/Ecosystems_Novus/job/Data-Services-Broker/job/csm-metrics-powerstore-pr-based-e2e/46/

baoy1
baoy1 previously approved these changes Aug 1, 2022
View reviewed changes
shaynafinocchiaro
shaynafinocchiaro reviewed Aug 1, 2022
View reviewed changes
.github/CODEOWNERS Outdated
@@ -17,6 +17,11 @@
# Shayna Finocchiaro (shaynafinocchiaro)
# Logan Jones (lj-software)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove Logan and Michael from the code owners list. Thank you!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed

@YianZong
* Reorganize columns in the topology dashboard
bec842b 
* Change the external IP into internal one in the UT
@YianZong YianZong force-pushed the feature-401-ReorgColumns branch from 5816c52 to bec842b Compare August 1, 2022 13:13
@YianZong
Copy link
Contributor Author

YianZong commented Aug 1, 2022

run e2e test

@YianZong
Copy link
Contributor Author

YianZong commented Aug 1, 2022

Updated the code owner file and the e2e is successful:
https://osj-sio-03-prd.cec.lab.emc.com/view/CSI-CSM-Consolidation/job/Ecosystems_Novus/job/Data-Services-Broker/job/karavi-topo-pr-based-e2e/56/

@YianZong
Copy link
Contributor Author

YianZong commented Aug 1, 2022

e2e pass

forrestxia
forrestxia approved these changes Aug 2, 2022
View reviewed changes
.github/CODEOWNERS

# for all files:
* @medegw01 @gallacher @tdawe @alikdell @atye @hoppea2 @coulof @shaynafinocchiaro @lj-software @sharmilarama
* @gallacher @tdawe @alikdell @atye @hoppea2 @coulof @shaynafinocchiaro @sharmilarama @forrestxia @YianZong @baoy1 @taohe1012 @P-Cao
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"# Michael Edegware (medegw01)" and "# Logan Jones (lj-software)" could be removed from the list. @YianZong

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@forrestxia already removed

@YianZong
Copy link
Contributor Author

YianZong commented Aug 2, 2022

Hi Code Owners,
Please kindly review the PR. Thanks!

@YianZong YianZong merged commit e06daba into main Aug 3, 2022
@YianZong YianZong deleted the feature-401-ReorgColumns branch August 3, 2022 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-Cao P-Cao P-Cao approved these changes

@baoy1 baoy1 baoy1 approved these changes

@forrestxia forrestxia forrestxia approved these changes

@taohe1012 taohe1012 taohe1012 approved these changes

@sharmilarama sharmilarama sharmilarama approved these changes

@shaynafinocchiaro shaynafinocchiaro shaynafinocchiaro approved these changes

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@atye atye Awaiting requested review from atye atye is a code owner

@hoppea2 hoppea2 Awaiting requested review from hoppea2 hoppea2 is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@YianZong @shaynafinocchiaro @sharmilarama @taohe1012 @forrestxia @baoy1 @P-Cao