* Reorganize columns in the topology dashboard

* Change the external IP into internal one in the UT
dell · Aug 1, 2022 · 0006943 · 0006943
1 parent e1a126f
commit 0006943
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -17,6 +17,11 @@
 # Shayna Finocchiaro (shaynafinocchiaro)
 # Logan Jones (lj-software)
 # Sharmila Ramamoorthy (sharmilarama)
+# Forrest Xia (forrestxia)
+# Yian Zong (YianZong)
+# Yiming Bao (baoy1)
+# Tao He (taohe1012)
+# Peter Cao (P-Cao)
 
 # for all files:
-* @medegw01 @gallacher @tdawe @alikdell @atye @hoppea2 @coulof @shaynafinocchiaro @lj-software @sharmilarama
+* @medegw01 @gallacher @tdawe @alikdell @atye @hoppea2 @coulof @shaynafinocchiaro @lj-software @sharmilarama @forrestxia @YianZong @baoy1 @taohe1012 @P-Cao
diff --git a/internal/k8s/volume_finder_test.go b/internal/k8s/volume_finder_test.go
@@ -228,7 +228,7 @@ func Test_K8sPersistentVolumeFinder(t *testing.T) {
 									VolumeAttributes: map[string]string{
 										"Name":              "persistent-volume-name-3",
 										"AccessZone":        "System",
-										"AzServiceIP":       "10.0.0.1",
+										"AzServiceIP":       "192.0.0.1",
 										"ClusterName":       "pieisi93x",
 										"ID":                "15",
 										"Path":              "/ifs/data/csi/persistent-volume-name-3",

diff --git a/internal/service/service.go b/internal/service/service.go
@@ -243,6 +243,7 @@ func supportedColumnPair(volume k8s.VolumeInfo) map[string]string {
 		"CSI Driver":     volume.Driver,
 		"Storage Pool":   volume.StoragePoolName,
 		"Storage System": volume.StorageSystem,
+		"Storage Class":  volume.StorageClass,
 	}
 }
 func canAddRow(volume k8s.VolumeInfo, lookUp []map[string]string) bool {