Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding UI check to PR template #114

Merged
merged 2 commits into from
May 24, 2022
Merged

Adding UI check to PR template #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab77093
Adding UI check to PR template
hoppea2 May 12, 2022
7e807b7
Update actions.yaml
shaynafinocchiaro May 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ List the GitHub issues impacted by this PR:
- [ ] I have verified that new and existing unit tests pass locally with my changes
- [ ] I have not allowed coverage numbers to degenerate
- [ ] I have maintained at least 90% code coverage
- [ ] I have inspected the Grafana dashboards to verify the data is displayed properly
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
Expand All @@ -24,3 +25,9 @@ Please describe the tests that you ran to verify your changes. Please also list

- [ ] Test A
- [ ] Test B

# Manual inspection of the GUI
I have verified that the dashboards show the data properly while generating I/O and storage resources

- [ ] Yes
- [ ] No
2 changes: 1 addition & 1 deletion .github/workflows/actions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ jobs:
- name: Checkout the code
uses: actions/checkout@v2
- name: Install Mockgen
run: go get github.com/golang/mock/[email protected]
run: go install github.com/golang/mock/[email protected]
- name: Get dependencies
run: go mod download
- name: Build csm-topology Docker Image
Expand Down