Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding UI check to PR template #114

Merged
merged 2 commits into from
May 24, 2022
Merged

Adding UI check to PR template #114

merged 2 commits into from
May 24, 2022

Conversation

hoppea2
Copy link
Collaborator

@hoppea2 hoppea2 commented May 12, 2022

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#279

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

sharmilarama
sharmilarama previously approved these changes May 12, 2022
View reviewed changes
@hoppea2
Copy link
Collaborator Author

hoppea2 commented May 13, 2022

e2e pass

@hoppea2 hoppea2 merged commit 51f0e05 into main May 24, 2022
@shaynafinocchiaro shaynafinocchiaro deleted the update-PR-template branch June 16, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharmilarama sharmilarama sharmilarama approved these changes

@shaynafinocchiaro shaynafinocchiaro shaynafinocchiaro approved these changes

@medegw01 medegw01 Awaiting requested review from medegw01

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@atye atye Awaiting requested review from atye atye is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hoppea2 @shaynafinocchiaro @sharmilarama