Update GO to 1.19 and format code

.github/workflows/actions.yml

@@ -58,10 +58,10 @@ jobs:
     name: Image Scanner
     runs-on: ubuntu-latest
     steps:
-      - name: Set up Go 1.18+
+      - name: Set up Go 1.19+
         uses: actions/setup-go@v2
         with:
-          go-version: ^1.18
+          go-version: ^1.19
         id: go
       - name: Checkout the code
         uses: actions/checkout@v2

.gitignore

@@ -1,2 +1,4 @@
 vendor/
 cmd/*/bin/
+**/.vscode/
+**/.idea/

go.mod

@@ -1,6 +1,6 @@
 module github.com/dell/karavi-metrics-powerflex
 
-go 1.18
+go 1.19
 
 require (
 	github.com/dell/goscaleio v1.7.0
@@ -52,11 +52,11 @@ require (
 	go.opentelemetry.io/otel/sdk v1.7.0 // indirect
 	go.opentelemetry.io/otel/trace v1.7.0 // indirect
 	go.opentelemetry.io/proto/otlp v0.16.0 // indirect
-	golang.org/x/net v0.0.0-20220127200216-cd36cc0744dd // indirect
+	golang.org/x/net v0.0.0-20221004154528-8021a29435af // indirect
 	golang.org/x/oauth2 v0.0.0-20211104180415-d3ed0bb246c8 // indirect
-	golang.org/x/sys v0.0.0-20220204135822-1c1b9b1eba6a // indirect
+	golang.org/x/sys v0.0.0-20220728004956-3c1f35247d10 // indirect
 	golang.org/x/term v0.0.0-20210927222741-03fcf44c2211 // indirect
-	golang.org/x/text v0.3.7 // indirect
+	golang.org/x/text v0.3.8 // indirect
 	golang.org/x/time v0.0.0-20211116232009-f0f3c7e86c11 // indirect
 	google.golang.org/appengine v1.6.7 // indirect
 	google.golang.org/genproto v0.0.0-20220204002441-d6cc3cc0770e // indirect

go.sum

@@ -408,8 +408,8 @@ golang.org/x/net v0.0.0-20210226172049-e18ecbb05110/go.mod h1:m0MpNAwzfU5UDzcl9v
 golang.org/x/net v0.0.0-20210316092652-d523dce5a7f4/go.mod h1:RBQZq4jEuRlivfhVLdyRGr576XBO4/greRjx4P4O3yc=
 golang.org/x/net v0.0.0-20210405180319-a5a99cb37ef4/go.mod h1:p54w0d4576C0XHj96bSt6lcn1PtDYWL6XObtHCRCNQM=
 golang.org/x/net v0.0.0-20211209124913-491a49abca63/go.mod h1:9nx3DQGgdP8bBQD5qxJ1jj9UTztislL4KSBs9R2vV5Y=
-golang.org/x/net v0.0.0-20220127200216-cd36cc0744dd h1:O7DYs+zxREGLKzKoMQrtrEacpb0ZVXA5rIwylE2Xchk=
-golang.org/x/net v0.0.0-20220127200216-cd36cc0744dd/go.mod h1:CfG3xpIq0wQ8r1q4Su4UZFWDARRcnwPjda9FqA0JpMk=
+golang.org/x/net v0.0.0-20221004154528-8021a29435af h1:wv66FM3rLZGPdxpYL+ApnDe2HzHcTFta3z5nsc13wI4=
+golang.org/x/net v0.0.0-20221004154528-8021a29435af/go.mod h1:YDH+HFinaLZZlnHAfSS6ZXJJ9M9t4Dl22yv3iI2vPwk=
 golang.org/x/oauth2 v0.0.0-20180821212333-d2e6202438be/go.mod h1:N/0e6XlmueqKjAGxoOufVs8QHGRruUQn6yWY3a++T0U=
 golang.org/x/oauth2 v0.0.0-20190226205417-e64efc72b421/go.mod h1:gOpvHmFTYa4IltrdGE7lF6nIHvwfUNPOp7c8zoXwtLw=
 golang.org/x/oauth2 v0.0.0-20190604053449-0f29369cfe45/go.mod h1:gOpvHmFTYa4IltrdGE7lF6nIHvwfUNPOp7c8zoXwtLw=
@@ -484,8 +484,8 @@ golang.org/x/sys v0.0.0-20210510120138-977fb7262007/go.mod h1:oPkhp1MJrh7nUepCBc
 golang.org/x/sys v0.0.0-20210615035016-665e8c7367d1/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/sys v0.0.0-20210630005230-0f9fa26af87c/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/sys v0.0.0-20210831042530-f4d43177bf5e/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
-golang.org/x/sys v0.0.0-20220204135822-1c1b9b1eba6a h1:ppl5mZgokTT8uPkmYOyEUmPTr3ypaKkg5eFOGrAmxxE=
-golang.org/x/sys v0.0.0-20220204135822-1c1b9b1eba6a/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
+golang.org/x/sys v0.0.0-20220728004956-3c1f35247d10 h1:WIoqL4EROvwiPdUtaip4VcDdpZ4kha7wBWZrbVKCIZg=
+golang.org/x/sys v0.0.0-20220728004956-3c1f35247d10/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/term v0.0.0-20201126162022-7de9c90e9dd1/go.mod h1:bj7SfCRtBDWHUb9snDiAeCFNEtKQo2Wmx5Cou7ajbmo=
 golang.org/x/term v0.0.0-20210615171337-6886f2dfbf5b/go.mod h1:jbD1KX2456YbFQfuXm/mYQcufACuNUgVhRMnK/tPxf8=
 golang.org/x/term v0.0.0-20210927222741-03fcf44c2211 h1:JGgROgKl9N8DuW20oFS5gxc+lE67/N3FcwmBPMe7ArY=
@@ -498,8 +498,9 @@ golang.org/x/text v0.3.3/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ=
 golang.org/x/text v0.3.4/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ=
 golang.org/x/text v0.3.5/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ=
 golang.org/x/text v0.3.6/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ=
-golang.org/x/text v0.3.7 h1:olpwvP2KacW1ZWvsR7uQhoyTYvKAupfQrRGBFM352Gk=
 golang.org/x/text v0.3.7/go.mod h1:u+2+/6zg+i71rQMx5EYifcz6MCKuco9NR6JIITiCfzQ=
+golang.org/x/text v0.3.8 h1:nAL+RVCQ9uMn3vJZbV+MRnydTJFPf8qqY42YiA6MrqY=
+golang.org/x/text v0.3.8/go.mod h1:E6s5w1FMmriuDzIBO73fBruAKo1PCIq6d2Q6DHfQ8WQ=
 golang.org/x/time v0.0.0-20181108054448-85acf8d2951c/go.mod h1:tRJNPiyCQ0inRvYxbN9jk5I+vvW/OXSQhTDSoE431IQ=
 golang.org/x/time v0.0.0-20190308202827-9d24e82272b4/go.mod h1:tRJNPiyCQ0inRvYxbN9jk5I+vvW/OXSQhTDSoE431IQ=
 golang.org/x/time v0.0.0-20191024005414-555d28b269f0/go.mod h1:tRJNPiyCQ0inRvYxbN9jk5I+vvW/OXSQhTDSoE431IQ=

internal/k8s/leader_elector.go

@@ -23,6 +23,7 @@ import (
 )
 
 // LeaderElectorGetter is an interface for initialize and check elected leader
+//
 //go:generate mockgen -destination=mocks/leader_elector_getter_mocks.go -package=mocks github.com/dell/karavi-metrics-powerflex/internal/k8s LeaderElectorGetter
 type LeaderElectorGetter interface {
 	InitLeaderElection(string, string) error

internal/k8s/node_finder.go

@@ -13,6 +13,7 @@ import (
 )
 
 // NodeGetter is an interface for getting a list of storage class information
+//
 //go:generate mockgen -destination=mocks/node_getter_mocks.go -package=mocks github.com/dell/karavi-metrics-powerflex/internal/k8s NodeGetter
 type NodeGetter interface {
 	GetNodes() (*corev1.NodeList, error)

internal/k8s/sdc_finder.go

@@ -15,6 +15,7 @@ import (
 )
 
 // KubernetesAPI is an interface for accessing the Kubernetes API
+//
 //go:generate mockgen -destination=mocks/kubernetes_api_mocks.go -package=mocks github.com/dell/karavi-metrics-powerflex/internal/k8s KubernetesAPI
 type KubernetesAPI interface {
 	GetCSINodes() (*v1.CSINodeList, error)

internal/k8s/storageclass_finder.go

@@ -13,6 +13,7 @@ import (
 )
 
 // StorageClassGetter is an interface for getting a list of storage class information
+//
 //go:generate mockgen -destination=mocks/storage_class_getter_mocks.go -package=mocks github.com/dell/karavi-metrics-powerflex/internal/k8s StorageClassGetter
 type StorageClassGetter interface {
 	GetStorageClasses() (*v1.StorageClassList, error)

internal/k8s/volume_finder.go

@@ -18,6 +18,7 @@ import (
 )
 
 // VolumeGetter is an interface for getting a list of persistent volume information
+//
 //go:generate mockgen -destination=mocks/volume_getter_mocks.go -package=mocks github.com/dell/karavi-metrics-powerflex/internal/k8s VolumeGetter
 type VolumeGetter interface {
 	GetPersistentVolumes() (*corev1.PersistentVolumeList, error)

internal/service/metrics.go

@@ -18,6 +18,7 @@ import (
 )
 
 // MetricsRecorder supports recording I/O metrics
+//
 //go:generate mockgen -destination=mocks/metrics_mocks.go -package=mocks github.com/dell/karavi-metrics-powerflex/internal/service MetricsRecorder,Float64UpDownCounterCreater
 type MetricsRecorder interface {
 	Record(ctx context.Context, meta interface{},
@@ -29,6 +30,7 @@ type MetricsRecorder interface {
 }
 
 // Float64UpDownCounterCreater creates a Float64UpDownCounter InstrumentProvider
+//
 //go:generate mockgen -destination=mocks/instrument_provider_mocks.go -package=mocks go.opentelemetry.io/otel/metric/instrument/asyncfloat64 InstrumentProvider
 type Float64UpDownCounterCreater interface {
 	AsyncFloat64() asyncfloat64.InstrumentProvider

internal/service/service.go

@@ -31,6 +31,7 @@ const (
 )
 
 // Service contains operations that would be used to interact with a PowerFlex system
+//
 //go:generate mockgen -destination=mocks/service_mocks.go -package=mocks github.com/dell/karavi-metrics-powerflex/internal/service Service
 type Service interface {
 	GetSDCs(context.Context, PowerFlexClient, SDCFinder) ([]StatisticsGetter, error)
@@ -42,6 +43,7 @@ type Service interface {
 }
 
 // StatisticsGetter supports getting statistics
+//
 //go:generate mockgen -destination=mocks/statistics_getter_mocks.go -package=mocks github.com/dell/karavi-metrics-powerflex/internal/service StatisticsGetter
 type StatisticsGetter interface {
 	GetStatistics() (*types.SdcStatistics, error)
@@ -50,12 +52,14 @@ type StatisticsGetter interface {
 }
 
 // VolumeStatisticsGetter supports getting statistics
+//
 //go:generate mockgen -destination=mocks/volume_statistics_getter_mocks.go -package=mocks github.com/dell/karavi-metrics-powerflex/internal/service VolumeStatisticsGetter
 type VolumeStatisticsGetter interface {
 	GetVolumeStatistics() (*types.VolumeStatistics, error)
 }
 
 // PowerFlexClient contains operations for a powerflex client
+//
 //go:generate mockgen -destination=mocks/powerflex_client_mocks.go -package=mocks github.com/dell/karavi-metrics-powerflex/internal/service PowerFlexClient
 type PowerFlexClient interface {
 	Authenticate(*sio.ConfigConnect) (sio.Cluster, error)
@@ -65,6 +69,7 @@ type PowerFlexClient interface {
 }
 
 // PowerFlexSystem contains operations for a powerflex system
+//
 //go:generate mockgen -destination=mocks/powerflex_system_mocks.go -package=mocks github.com/dell/karavi-metrics-powerflex/internal/service PowerFlexSystem
 type PowerFlexSystem interface {
 	FindSdc(string, string) (*sio.Sdc, error)
@@ -78,36 +83,42 @@ type PowerFlexService struct {
 }
 
 // SDCFinder is used to find SDC GUIDs
+//
 //go:generate mockgen -destination=mocks/sdc_finder_mocks.go -package=mocks github.com/dell/karavi-metrics-powerflex/internal/service SDCFinder
 type SDCFinder interface {
 	GetSDCGuids() ([]string, error)
 }
 
 // StorageClassFinder is used to find storage classes in kubernetes
+//
 //go:generate mockgen -destination=mocks/storage_class_finder_mocks.go -package=mocks github.com/dell/karavi-metrics-powerflex/internal/service StorageClassFinder
 type StorageClassFinder interface {
 	GetStorageClasses() ([]v1.StorageClass, error)
 }
 
 // VolumeFinder is used to find volume information in kubernetes
+//
 //go:generate mockgen -destination=mocks/volume_finder_mocks.go -package=mocks github.com/dell/karavi-metrics-powerflex/internal/service VolumeFinder
 type VolumeFinder interface {
 	GetPersistentVolumes() ([]k8s.VolumeInfo, error)
 }
 
 // NodeFinder is a node finder that will query the Kubernetes API for a slice of cluster nodes
+//
 //go:generate mockgen -destination=mocks/node_finder_mocks.go -package=mocks github.com/dell/karavi-metrics-powerflex/internal/service NodeFinder
 type NodeFinder interface {
 	GetNodes() ([]corev1.Node, error)
 }
 
 // StoragePoolStatisticsGetter supports getting storage pool statistics
+//
 //go:generate mockgen -destination=mocks/storage_pool_statistics_getter_mocks.go -package=mocks github.com/dell/karavi-metrics-powerflex/internal/service StoragePoolStatisticsGetter
 type StoragePoolStatisticsGetter interface {
 	GetStatistics() (*types.Statistics, error)
 }
 
 // LeaderElector will elect a leader
+//
 //go:generate mockgen -destination=mocks/leader_elector_mocks.go -package=mocks github.com/dell/karavi-metrics-powerflex/internal/service LeaderElector
 type LeaderElector interface {
 	InitLeaderElection(string, string) error

opentelemetry/exporters/types.go

@@ -11,6 +11,7 @@ import "go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc"
 //  http://www.apache.org/licenses/LICENSE-2.0
 
 // Otlexporter is an interface for all OpenTelemetry exporters
+//
 //go:generate mockgen -destination=mocks/otlexporters_mocks.go -package=exportermocks github.com/dell/karavi-metrics-powerflex/opentelemetry/exporters Otlexporter
 type Otlexporter interface {
 	InitExporter(...otlpmetricgrpc.Option) error