Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GO to 1.19 and format code #135

Merged
merged 1 commit into from
Oct 13, 2022
Merged

Update GO to 1.19 and format code #135

merged 1 commit into from
Oct 13, 2022

Conversation

baoy1
Copy link
Contributor

@baoy1 baoy1 commented Oct 11, 2022

Description

Update GO to 1.19 and format code

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#491

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have inspected the Grafana dashboards to verify the data is displayed properly
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • make check test
    image

Manual inspection of the GUI

I have verified that the dashboards show the data properly while generating I/O and storage resources

  • Yes
  • No

@baoy1
Copy link
Contributor Author

baoy1 commented Oct 11, 2022

allowedlist.yaml is temporarily added to address vulnerability CVE-2022-27664.

@baoy1
Copy link
Contributor Author

baoy1 commented Oct 11, 2022

run e2e test

forrestxia
forrestxia previously approved these changes Oct 11, 2022
gallacher
gallacher previously approved these changes Oct 11, 2022
taohe1012
taohe1012 previously approved these changes Oct 12, 2022
@baoy1 baoy1 dismissed stale reviews from taohe1012, gallacher, and forrestxia via bd6c3d3 October 12, 2022 12:44
@baoy1 baoy1 force-pushed the feature-update-go-1.19 branch from 631f3a0 to bd6c3d3 Compare October 12, 2022 12:44
@baoy1
Copy link
Contributor Author

baoy1 commented Oct 12, 2022

run e2e test

@baoy1 baoy1 merged commit 164f366 into main Oct 13, 2022
@baoy1 baoy1 deleted the feature-update-go-1.19 branch October 13, 2022 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants