Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint issues #257

Merged
merged 5 commits into from
Jan 10, 2024
Merged

Fix lint issues #257

merged 5 commits into from
Jan 10, 2024

Conversation

KerryKovacevic
Copy link
Contributor

@KerryKovacevic KerryKovacevic commented Jan 9, 2024

Description

Fixed formating (gofumpt).
Disabled "G402: TLS InsecureSkipVerify set true. (gosec)", required until further implementation work is done on cert validation with storage arrays.
Removed pprof import.
Combined hardcoded tokens into yaml file.
Updated linter version.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#926

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@csmbot
Copy link
Collaborator

csmbot commented Jan 9, 2024

Can one of the admins verify this patch?

xuluna
xuluna previously approved these changes Jan 9, 2024
PeresKereotubo
PeresKereotubo previously approved these changes Jan 9, 2024
@xuluna
Copy link
Contributor

xuluna commented Jan 9, 2024

@KerryKovacevic please make sure the linters check is green before merging. Before running PR e2e, you would also need a pipeline PR to change the PR job to check if linters passes (it is disabled for now).

@KerryKovacevic KerryKovacevic dismissed stale reviews from PeresKereotubo and xuluna via 146b63b January 9, 2024 16:01
.github/workflows/linters.yaml Outdated Show resolved Hide resolved
@KerryKovacevic
Copy link
Contributor Author

run e2e test

@dell dell deleted a comment from KerryKovacevic Jan 9, 2024
@KerryKovacevic
Copy link
Contributor Author

e2e pass

@KerryKovacevic KerryKovacevic merged commit 0767ae2 into main Jan 10, 2024
8 checks passed
@KerryKovacevic KerryKovacevic deleted the kerry/lint branch January 10, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants