-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lint issues #257
Merged
Merged
Fix lint issues #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KerryKovacevic
requested review from
gallacher,
tdawe,
alikdell,
atye,
hoppea2,
coulof,
shaynafinocchiaro,
sharmilarama,
EvgenyUglov,
bjiang27,
xuluna,
PeresKereotubo,
EmilyKatdell,
MaksimDell,
jooseppi-luna,
Sahiba-Gupta,
jackieung-dell,
rodrigobassil,
anandrajak1 and
abhi16394
as code owners
January 9, 2024 14:43
Can one of the admins verify this patch? |
xuluna
previously approved these changes
Jan 9, 2024
PeresKereotubo
previously approved these changes
Jan 9, 2024
@KerryKovacevic please make sure the linters check is green before merging. Before running PR e2e, you would also need a pipeline PR to change the PR job to check if linters passes (it is disabled for now). |
KerryKovacevic
dismissed stale reviews from PeresKereotubo and xuluna
via
January 9, 2024 16:01
146b63b
PeresKereotubo
approved these changes
Jan 9, 2024
xuluna
approved these changes
Jan 9, 2024
EmilyKatdell
approved these changes
Jan 9, 2024
run e2e test |
e2e pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed formating (gofumpt).
Disabled "G402: TLS InsecureSkipVerify set true. (gosec)", required until further implementation work is done on cert validation with storage arrays.
Removed pprof import.
Combined hardcoded tokens into yaml file.
Updated linter version.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration