Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE]: Fixing the linting, formatting and vetting issues #926

Closed
shanduur-dell opened this issue Aug 2, 2023 · 0 comments
Closed

[FEATURE]: Fixing the linting, formatting and vetting issues #926

shanduur-dell opened this issue Aug 2, 2023 · 0 comments
Assignees
@cbartoszDell
Labels
area/cert-csi Issues pertaining to Cert CSI area/csi-powerflex Issue pertains to the CSI Driver for Dell EMC PowerFlex area/csi-powermax Issue pertains to the CSI Driver for Dell EMC PowerMax area/csi-powerscale Issue pertains to the CSI Driver for Dell EMC PowerScale area/csi-powerstore Issue pertains to the CSI Driver for Dell EMC PowerStore area/csi-unity Issue pertains to the CSI Driver for Dell EMC Unity area/csm-application-mobility area/csm-authorization Issue pertains to the CSM Authorization module area/csm-observability Issue pertains to the CSM Observability module area/csm-operator area/csm-replication Issue pertains to the CSM Replication module area/csm-resiliency Issue pertains to the CSM Resiliency module type/feature A feature. This label is applied to a feature issues.
Milestone
v1.10.0

Comments

@shanduur-dell
Copy link

Describe the solution you'd like
I'd like to see the golangci-lint linter and GitHub Action configured for dell CSM Repositories.

The basic configuration should include the following linters:

  • gofumpt - A stricter replacement for gofmt.
  • gosec - Inspects source code for security problems.
  • govet - Check for correctness of programs.
  • revive - Drop-in replacement of golint.

Describe alternatives you've considered
golangci-lint does not have a real alternative. It aggregates linters, and provides easy configuration to them.

Additional context
This was discussed and accepted during meeting on 2023-08-01.
@shanduur-dell shanduur-dell added type/feature A feature. This label is applied to a feature issues. area/csm-observability Issue pertains to the CSM Observability module area/csm-replication Issue pertains to the CSM Replication module area/csm-resiliency Issue pertains to the CSM Resiliency module area/csm-authorization Issue pertains to the CSM Authorization module area/csi-powerflex Issue pertains to the CSI Driver for Dell EMC PowerFlex area/csi-powerstore Issue pertains to the CSI Driver for Dell EMC PowerStore area/csi-powerscale Issue pertains to the CSI Driver for Dell EMC PowerScale area/csi-unity Issue pertains to the CSI Driver for Dell EMC Unity area/csi-powermax Issue pertains to the CSI Driver for Dell EMC PowerMax area/dell-csi-operator area/csm-operator area/csm-application-mobility area/cert-csi Issues pertaining to Cert CSI labels Aug 2, 2023
This was referenced Aug 2, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
This was referenced Aug 2, 2023
Merged
Merged
Merged
Merged
@shanduur-dell shanduur-dell added this to the v1.8.0 milestone Aug 2, 2023
@shanduur-dell shanduur-dell self-assigned this Aug 2, 2023
@adarsh-dell adarsh-dell changed the title [FEATURE]: set up golangci-lint for all CSM repositories [FEATURE]: Set up golangci-lint for all CSM repositories Aug 9, 2023
@lukeatdell lukeatdell mentioned this issue Aug 9, 2023
Merged
8 tasks
@tssushma tssushma removed this from the v1.8.0 milestone Aug 30, 2023
@VamsiSiddu-7 VamsiSiddu-7 modified the milestone: v1.8.0 Sep 6, 2023
@shanmydell shanmydell mentioned this issue Sep 25, 2023
Merged
8 tasks
This was referenced Sep 27, 2023
Merged
Merged
@xuluna xuluna mentioned this issue Dec 18, 2023
Merged
8 tasks
@shanmydell shanmydell modified the milestone: v1.10.0 Jan 1, 2024
@xuluna xuluna mentioned this issue Jan 2, 2024
Merged
8 tasks
@KerryKovacevic KerryKovacevic mentioned this issue Jan 9, 2024
Merged
10 tasks
@shanmydell shanmydell added this to the v1.10.0 milestone Jan 16, 2024
@shanmydell shanmydell changed the title [FEATURE]: Set up golangci-lint for all CSM repositories [FEATURE]: Fixing the linting, formatting and vetting issues Jan 16, 2024
@donatwork donatwork mentioned this issue Feb 7, 2024
Merged
10 tasks
This was referenced Feb 26, 2024
Merged
Merged
Merged
Merged
@alikdell alikdell mentioned this issue Mar 4, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cbartoszDell cbartoszDell

Labels
area/cert-csi Issues pertaining to Cert CSI area/csi-powerflex Issue pertains to the CSI Driver for Dell EMC PowerFlex area/csi-powermax Issue pertains to the CSI Driver for Dell EMC PowerMax area/csi-powerscale Issue pertains to the CSI Driver for Dell EMC PowerScale area/csi-powerstore Issue pertains to the CSI Driver for Dell EMC PowerStore area/csi-unity Issue pertains to the CSI Driver for Dell EMC Unity area/csm-application-mobility area/csm-authorization Issue pertains to the CSM Authorization module area/csm-observability Issue pertains to the CSM Observability module area/csm-operator area/csm-replication Issue pertains to the CSM Replication module area/csm-resiliency Issue pertains to the CSM Resiliency module type/feature A feature. This label is applied to a feature issues.
Projects
None yet
Milestone
v1.10.0
Development

No branches or pull requests
6 participants
@gallacher @shanmydell @tssushma @VamsiSiddu-7 @shanduur-dell @cbartoszDell