Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug-350]: Clarify role update error messages #195

Merged
merged 6 commits into from
Nov 8, 2022
Merged

[bug-350]: Clarify role update error messages #195

merged 6 commits into from
Nov 8, 2022

Conversation

atye
Copy link
Contributor

@atye atye commented Nov 3, 2022 •
edited
Loading

Description

  • Updates error messages of karavictl role update to clarify that only the quota of a role can be updated
  • If a role is not found, the error message shows the RoleKey, the unique identifier for the role instead of just the role name
  • Adds unit test to role-service for non-quota update

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#530

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

shaynafinocchiaro
shaynafinocchiaro reviewed Nov 3, 2022
View reviewed changes
cmd/karavictl/cmd/role_update.go Outdated
Short: "Update one or more Karavi roles",
Long: `Updates one or more Karavi roles`,
Short: "Update the quota of one or more Karavi roles",
Long: `Updates the quota of one or more Karavi roles`,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we still refer to this as a "Karavi" role?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, updated.

@atye
Copy link
Contributor Author

atye commented Nov 8, 2022

e2e pass

@atye atye merged commit 4f4a715 into main Nov 8, 2022
@atye atye deleted the bug-350-role-update branch November 8, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IsaiasA1 IsaiasA1 IsaiasA1 approved these changes

@sharmilarama sharmilarama sharmilarama approved these changes

@shaynafinocchiaro shaynafinocchiaro shaynafinocchiaro approved these changes

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@hoppea2 hoppea2 Awaiting requested review from hoppea2 hoppea2 is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@EvgenyUglov EvgenyUglov Awaiting requested review from EvgenyUglov EvgenyUglov is a code owner

@bjiang27 bjiang27 Awaiting requested review from bjiang27 bjiang27 is a code owner

@aqu-dell aqu-dell Awaiting requested review from aqu-dell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atye @shaynafinocchiaro @sharmilarama @IsaiasA1