Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel tenant revokation on tenant deletion #160

Merged
merged 2 commits into from
Mar 2, 2022

Conversation

atye
Copy link
Contributor

@atye atye commented Mar 1, 2022

Description

This fixes a bug where a tenant is still considered revoked after it is deleted. A deleted tenant should not exist in the system.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#208

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

This was tested with a new unit test and verified in the e2e job.

go test -count=1 -cover -race -timeout 30s -short ./...
?       karavi-authorization/cmd/karavictl      [no test files]
ok      karavi-authorization/cmd/karavictl/cmd  2.267s  coverage: 61.0% of statements
ok      karavi-authorization/cmd/proxy-server   0.076s  coverage: 4.2% of statements
?       karavi-authorization/cmd/sidecar-proxy  [no test files]
ok      karavi-authorization/cmd/tenant-service 0.046s  coverage: 9.4% of statements
ok      karavi-authorization/deploy     0.133s  coverage: 87.5% of statements
?       karavi-authorization/internal/decision  [no test files]
ok      karavi-authorization/internal/powerflex 9.581s  coverage: 92.6% of statements
ok      karavi-authorization/internal/proxy     6.421s  coverage: 68.3% of statements
ok      karavi-authorization/internal/quota     0.316s  coverage: 90.1% of statements
ok      karavi-authorization/internal/roles     0.040s  coverage: 93.2% of statements
ok      karavi-authorization/internal/tenantsvc 1.460s  coverage: 82.3% of statements
ok      karavi-authorization/internal/token     0.034s  coverage: 100.0% of statements
ok      karavi-authorization/internal/token/jwx 0.041s  coverage: 71.7% of statements
ok      karavi-authorization/internal/web       0.041s  coverage: 6.2% of statements
?       karavi-authorization/pb [no test files]

@atye
Copy link
Contributor Author

atye commented Mar 2, 2022

run e2e test

@atye atye merged commit 3a1e46d into main Mar 2, 2022
@atye atye deleted the bug-208-cancel-revokation-on-delete branch March 2, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants