[charts/karavi-observability] Make app.kubernetes.io/name and name consistent
#107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coulof
requested review from
alikdell,
atye,
gallacher,
hoppea2,
LJ-Software,
medegw01,
sharmilarama,
shaynafinocchiaro and
tdawe
as code owners
LJ-Software
approved these changes
Feb 10, 2022
gallacher
approved these changes
Feb 14, 2022
LJ-Software
reviewed
Feb 14, 2022
LJ-Software
pushed a commit
that referenced
this pull request
Mar 23, 2022
* feature-112: Deprecate injection (#105) * enable auth sidecar * fix manifest * finish helm deployment of auth sidecar * update version * fix linting * fix chart version * add release branch to helm validations * Make `app.kubernetes.io/name` and `name` consistent (#107) * [charts/karavi-observability] Updated otel-collector and cert manager for observability helm chart (#106) * updated collecter config to use proper tls key * fixed otel collecter endpoint * updated cert-manager chart version * updatec otel-collecter image version * helm chart image version updates for CSM 1.2 release Co-authored-by: Aaron Tye <[email protected]> Co-authored-by: coulof <[email protected]> Co-authored-by: Hoppe, Alexander <[email protected]>
sharmilarama
added a commit
that referenced
this pull request
May 24, 2022
* feature-112: Deprecate injection (#105) * enable auth sidecar * fix manifest * finish helm deployment of auth sidecar * update version * fix linting * fix chart version * add release branch to helm validations * Make `app.kubernetes.io/name` and `name` consistent (#107) * [charts/karavi-observability] Updated otel-collector and cert manager for observability helm chart (#106) * updated collecter config to use proper tls key * fixed otel collecter endpoint * updated cert-manager chart version * updatec otel-collecter image version * helm chart image version updates for CSM 1.2 release * charts/karavi-observability: Patch v1.1.1 updates (#110) * revert OTEL (#115) * revert OTEL changes (#116) Co-authored-by: Aaron Tye <[email protected]> Co-authored-by: coulof <[email protected]> Co-authored-by: Logan Jones <[email protected]> Co-authored-by: Hoppe, Alexander <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a new chart?
No
What this PR does / why we need it:
It replaces the
app.kubernetes.io/namewithnameof the application.It is better to be consistent between these and generally speaking the names should be compatible with DNS names (i.e. no
_accepted).Which issue(s) is this PR associated with:
dell/csm/#186
Special notes for your reviewer:
Checklist:
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[charts_dir/mychartname]) if applicable