Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: CSM Observability helm charts: Make app.kubernetes.io/name and name consistent #186

Closed
hoppea2 opened this issue Feb 14, 2022 · 0 comments
Assignees
Labels
type/bug Something isn't working. This is the default label associated with a bug issue.
Milestone

Comments

@hoppea2
Copy link
Collaborator

hoppea2 commented Feb 14, 2022

Bug Description

We should replace the app.kubernetes.io/name with name of the application.

It is better to be consistent between these and generally speaking the names should be compatible with DNS names (i.e. no _ accepted).

Logs

no logs available

Screenshots

No response

Additional Environment Information

No response

Steps to Reproduce

inspect helm charts

Expected Behavior

Best practice is that app.kubernetes.io/name and name are consistent

CSM Driver(s)

N/A

Installation Type

No response

Container Storage Modules Enabled

Observability v.1.1

Container Orchestrator

K8s 1.23

Operating System

CentOS 7

@hoppea2 hoppea2 added needs-triage Issue requires triage. type/bug Something isn't working. This is the default label associated with a bug issue. and removed needs-triage Issue requires triage. labels Feb 14, 2022
@hoppea2 hoppea2 added this to the v1.2.0 milestone Feb 14, 2022
@coulof coulof closed this as completed Feb 16, 2022
@gallacher gallacher changed the title [BUG]: CSM Observability helm charts: Make app.kubernetes.io/name and name consistent [BUG]: CSM Observability helm charts: Make app.kubernetes.io/name and name consistent Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working. This is the default label associated with a bug issue.
Projects
None yet
Development

No branches or pull requests

2 participants