CSM Replication Support For PowerScale #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IliaRN
requested review from
bpjain2004,
nitesh3108,
prablr79,
randeepdell and
Sakshi-dell
as code owners
walker2
approved these changes
Jan 27, 2022
randeepdell
reviewed
Jan 28, 2022
| p := &Policies{} | ||
| err = client.Get(ctx, policiesPath, name, nil, nil, &p) | ||
| if err != nil || len(p.Policy) == 0 { | ||
| return nil, err |
There was a problem hiding this comment.
In a scenario where err is nil and len(p.Policy)==0 , we will be sending nil, nil essentially.
May be we can consider creating an err and returning it.
|
Need to rebase again, this PR shows changes that are already merged. |
IliaRN
force-pushed
the
feature/replication
branch
from
e1a5804 to
2bec035
Compare
IliaRN
force-pushed
the
feature/replication
branch
from
2bec035 to
67f809d
Compare
walker2
approved these changes
Jan 28, 2022
bpjain2004
approved these changes
Jan 28, 2022
|
@IliaRN can you check few comments ? post addressing that we can merge this PR. |
|
@randeepsharma is rebase is done for this PR ? |
Yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission checklist
GitHub Issues
List the GitHub issues impacted by this PR:
Common PR Checklist:
Description of your changes:
This PR addresses an issue with CSM Replication Support For PowerScale. Added initial replication code and DeletePolicy method.