fix issue with injector #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobGros
requested review from
abhi16394,
mjsdell,
nb950,
yifeijin,
jooseppi-luna and
bharathsreekanth
9 tasks
|
do you need to update the grpc v1.38.0 go.mod to latest ? |
nb950
reviewed
Feb 15, 2022
No, issue was with driver go.mod using grpc 1.43 |
jooseppi-luna
approved these changes
Feb 15, 2022
rbo54
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grpc 1.39 + introduced a change to metadata.FromIncomingContext. Instead of returning md, it would return a copy. This caused an issue for CSI-PowerFlex (and possibly other drivers) because we ended up injecting the request ID into the metadata's copy, and not the metadata itself. This resulted in logs appearing like:
"time="2022-02-07T17:01:52Z" level=info msg="/csi.v1.Controller/ControllerUnpublishVolume: : VolumeId=4d4a2e5a36080e0f-a23ae0a7000001c0, NodeId=63C568BC-7F0B-5151-B989-EEACA0293D70, XXX_NoUnkeyedLiteral={}, XXX_sizecache=0""instead of:
"time="2022-02-07T17:01:52Z" level=info msg="/csi.v1.Controller/ControllerUnpublishVolume: REQ 2515: VolumeId=4d4a2e5a36080e0f-a23ae0a7000001c0, NodeId=63C568BC-7F0B-5151-B989-EEACA0293D70, XXX_NoUnkeyedLiteral={}, XXX_sizecache=0"Issue: dell/csm#189