Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use modified gocsi #73

Merged
merged 2 commits into from
Feb 18, 2022
Merged

use modified gocsi #73

merged 2 commits into from
Feb 18, 2022

Conversation

JacobGros
Copy link
Collaborator

@JacobGros JacobGros commented Feb 15, 2022

Description

This PR uses a local version of gocsi to fix issues we saw with Req and Rep numbers not being recorded in logs.
This PR is dependent on dell/gocsi#7 being merged first for it to work.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#189

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Deployed image with these changes and fixed gocsi library and checked logs, results looked good:
time="2022-02-15T02:05:46Z" level=info msg="/csi.v1.Node/NodeGetCapabilities: REP 0138: Capabilities=[rpc:<type:EXPAND_VOLUME >  rpc:<type:SINGLE_NODE_MULTI_WRITER > ], XXX_NoUnkeyedLiteral={}, XXX_sizecache=0"

Copy link
Collaborator

@jooseppi-luna jooseppi-luna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM we'll just have to figure out a way to handle the issues in gocsi

@JacobGros JacobGros merged commit 8009afd into main Feb 18, 2022
@anandrajak1 anandrajak1 deleted the use-correct-gocsi branch October 17, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants