Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved ProbeController conflict by adding common protobuf #13

Merged
merged 2 commits into from
Dec 17, 2021

Conversation

walker2
Copy link
Contributor

@walker2 walker2 commented Dec 15, 2021

Description

Resolved conflict between replication and volume group snapshot extensions by adding separate common protobuf that contains ProbeController method

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#128

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

maxan98
maxan98 previously approved these changes Dec 15, 2021
common/common.proto Show resolved Hide resolved
common/go.mod Show resolved Hide resolved
@walker2 walker2 merged commit 58de430 into main Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants