Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added registration for VGS and replication CSI extension using updated csi-extensions #41

Merged
merged 2 commits into from
Dec 17, 2021

Conversation

walker2
Copy link
Contributor

@walker2 walker2 commented Dec 15, 2021

Description

Added registration for VGS and replication CSI extension using updated csi-extensions

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#128

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

Warning

This PR will be changed when dell/dell-csi-extensions#13 is merged

@harishp8889 harishp8889 requested a review from kumarp20 December 16, 2021 06:38
go.mod Show resolved Hide resolved
@harishp8889 harishp8889 merged commit b49f482 into main Dec 17, 2021
@walker2
Copy link
Contributor Author

walker2 commented Dec 17, 2021

@harishp8889 I think you merged it a little too early to the main, I haven't changed replace directive to new ones, I can't guarantee it will work.
I specifically put a warning to do that

@walker2
Copy link
Contributor Author

walker2 commented Dec 17, 2021

@harishp8889 I think you merged it a little too early to the main, I haven't changed replace directive to new ones, I can't guarantee it will work. I specifically put a warning to do that

And we need also to create PRs to change both VGS and replication controller to use a newer version of extensions, otherwise sidecars will fail gRPC requests

@harishp8889 harishp8889 deleted the feature/vgs-ext-support branch December 23, 2021 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants