Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try fix actions #72

Merged
merged 3 commits into from
Apr 7, 2022
Merged

try fix actions #72

merged 3 commits into from
Apr 7, 2022

Conversation

nb950
Copy link
Contributor

@nb950 nb950 commented Apr 6, 2022 •
edited
Loading

Description

uncomment actions to enable tests and scans

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#243

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • manual build ok , manual unit test ok

@rajendraindukuri
Copy link
Collaborator

@nb950 I think this PR should be linked to github issue dell/csm#243 . Can you please check?

@nb950 nb950 merged commit 7f1d2c2 into main Apr 7, 2022
@rensyct rensyct deleted the fix-actions-v1alpha2 branch July 18, 2022 12:17
ChristianAtDell added a commit that referenced this pull request Oct 15, 2024
@ChristianAtDell
try fix actions (#72)
718ab0a 
* try fix actions

* fix scan errors

* fix dockerfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajendraindukuri rajendraindukuri rajendraindukuri approved these changes

@jooseppi-luna jooseppi-luna jooseppi-luna approved these changes

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth bharathsreekanth is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@JacobGros JacobGros Awaiting requested review from JacobGros JacobGros is a code owner

@karthikk92 karthikk92 Awaiting requested review from karthikk92 karthikk92 is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@medegw01 medegw01 Awaiting requested review from medegw01

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

@prasar6 prasar6 Awaiting requested review from prasar6

@rensyct rensyct Awaiting requested review from rensyct

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@yifeijin yifeijin Awaiting requested review from yifeijin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nb950 @rajendraindukuri @jooseppi-luna