Skip to content

Commit

Permalink
try fix actions (#72)
Browse files Browse the repository at this point in the history
* try fix actions

* fix scan errors

* fix dockerfile
  • Loading branch information
ChristianAtDell committed Oct 15, 2024
1 parent e1d6943 commit 718ab0a
Show file tree
Hide file tree
Showing 3 changed files with 70 additions and 65 deletions.
3 changes: 3 additions & 0 deletions .github/containerscan/allowedlist.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ general:
- CVE-2022-25236
- CVE-2021-44568
- CVE-2022-24407
- CVE-2022-0778
- CVE-2022-26280
- CVE-2018-25032
bestPracticeViolations:
# list of best practies violatied that needs a fix
- DKL-DI-0006
Expand Down
130 changes: 65 additions & 65 deletions .github/workflows/actions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,16 @@ on:
pull_request:
branches: [ main ]
jobs:
# code-check:
# name: Check Go formatting, linting, vetting
# runs-on: ubuntu-latest
# steps:
# - name: Checkout the code
# uses: actions/checkout@v2
# - name: Run the formatter, linter, and vetter
# uses: dell/common-github-actions/go-code-formatter-linter-vetter@update-go-version
# with:
# directories: ./...
code-check:
name: Check Go formatting, linting, vetting
runs-on: ubuntu-latest
steps:
- name: Checkout the code
uses: actions/checkout@v2
- name: Run the formatter, linter, and vetter
uses: dell/common-github-actions/go-code-formatter-linter-vetter@update-go-version
with:
directories: ./...
sanitize:
name: Check for forbidden words
runs-on: ubuntu-latest
Expand All @@ -25,41 +25,41 @@ jobs:
uses: dell/common-github-actions/code-sanitizer@main
with:
args: /github/workspace
# test_controller:
# name: Run Go unit tests on controller and check package coverage
# runs-on: ubuntu-latest
# steps:
# - name: Checkout the code
# uses: actions/checkout@v2
# - name: Checkout csm-operator
# uses: actions/checkout@v2
# with:
# repository: 'dell/csm-operator'
# path: 'csm-operator'
# - name: Run unit tests and check package coverage
# uses: dell/common-github-actions/go-code-tester@csm-operator-controllers
# with:
# threshold: 84
# test_driver:
# name: Run Go unit tests on driver and check package coverage
# runs-on: ubuntu-latest
# steps:
# - name: Checkout the code
# uses: actions/checkout@v2
# - name: Run unit tests and check package coverage
# uses: dell/common-github-actions/go-code-tester@csm-operator-drivers
# with:
# threshold: 92
# go_security_scan:
# name: Go security
# runs-on: ubuntu-latest
# steps:
# - name: Checkout the code
# uses: actions/checkout@v2
# - name: Run Go Security
# uses: securego/gosec@master
# with:
# args: -exclude-dir=tests ./...
test_controller:
name: Run Go unit tests on controller and check package coverage
runs-on: ubuntu-latest
steps:
- name: Checkout the code
uses: actions/checkout@v2
- name: Checkout csm-operator
uses: actions/checkout@v2
with:
repository: 'dell/csm-operator'
path: 'csm-operator'
- name: Run unit tests and check package coverage
uses: dell/common-github-actions/go-code-tester@csm-operator-controllers
with:
threshold: 84
test_driver:
name: Run Go unit tests on driver and check package coverage
runs-on: ubuntu-latest
steps:
- name: Checkout the code
uses: actions/checkout@v2
- name: Run unit tests and check package coverage
uses: dell/common-github-actions/go-code-tester@csm-operator-drivers
with:
threshold: 92
go_security_scan:
name: Go security
runs-on: ubuntu-latest
steps:
- name: Checkout the code
uses: actions/checkout@v2
- name: Run Go Security
uses: securego/gosec@master
with:
args: -exclude-dir=tests ./...
malware_security_scan:
name: Malware Scanner
runs-on: ubuntu-latest
Expand All @@ -71,23 +71,23 @@ jobs:
with:
directories: .
options: -ri
# image_security_scan:
# name: Image Scanner
# runs-on: ubuntu-latest
# env:
# BASE_IMG : ubuntu:latest
# steps:
# - name: Set up Go 1.17+
# uses: actions/setup-go@v2
# with:
# go-version: ^1.17
# id: go
# - name: Checkout the code
# uses: actions/checkout@v2
# - name: Build Docker Images
# run: DEFAULT_IMG=csm-operator:latest make docker-build
# - name: Scan controller Image
# uses: Azure/container-scan@v0
# with:
# image-name: csm-operator:latest
# severity-threshold: HIGH
image_security_scan:
name: Image Scanner
runs-on: ubuntu-latest
env:
BASE_IMG : ubuntu:latest
steps:
- name: Set up Go 1.17+
uses: actions/setup-go@v2
with:
go-version: ^1.17
id: go
- name: Checkout the code
uses: actions/checkout@v2
- name: Build Docker Images
run: DEFAULT_IMG=csm-operator:latest make docker-build
- name: Scan controller Image
uses: Azure/container-scan@v0
with:
image-name: csm-operator:latest
severity-threshold: HIGH
2 changes: 2 additions & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ ENV USER_UID=1001 \
WORKDIR /
COPY --from=builder /workspace/manager .
COPY operatorconfig/ /etc/config/dell-csm-operator
RUN chmod a-w /usr/bin/chage
RUN rm -rf tmp
LABEL vendor="Dell Inc." \
name="dell-csm-operator" \
summary="Operator for installing Dell CSI Drivers and Dell CSM Modules" \
Expand Down

0 comments on commit 718ab0a

Please sign in to comment.