Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update rep-controller image #147

Merged
merged 1 commit into from
Dec 1, 2022
Merged

update rep-controller image #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bundle/manifests/dell-csm-operator.clusterserviceversion.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ metadata:
"value": "5m"
}
],
"image": "dellemc/dell-replication-controller:v1.3.0",
"image": "dellemc/dell-replication-controller:v1.3.1",
"name": "dell-replication-controller-manager"
}
],
Expand Down
2 changes: 1 addition & 1 deletion config/samples/storage_v1_csm_powerscale.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ spec:
- name: dell-replication-controller-manager
# image: Defines controller image. This shouldn't be changed
# Allowed values: string
image: dellemc/dell-replication-controller:v1.3.0
image: dellemc/dell-replication-controller:v1.3.1
envs:
# TARGET_CLUSTERS_IDS: comma separated list of clusters id of the targets clusters. DO NOT include the source(wherever CSM Operator is deployed) cluster id
# Allowed values: string
Expand Down
3 changes: 0 additions & 3 deletions operatorconfig/moduleconfig/common/version-values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,10 @@ powerflex:
# List of Driver versions and modules that supports the version
v2.3.0:
authorization: "v1.3.0"
replication: "v1.3.0"
bharathsreekanth marked this conversation as resolved.
Show resolved Hide resolved
observability: "v1.2.0"
v2.4.0:
authorization: "v1.4.0"
replication: "v1.3.0"
observability: "v1.3.0"
v2.5.0:
authorization: "v1.5.0"
replication: "v1.3.0"
observability: "v1.4.0"
2 changes: 1 addition & 1 deletion pkg/modules/replication.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ func getReplicaController(op utils.OperatorConfig, cr csmv1.ContainerStorageModu
replicaCount := "1"
retryMin := "1s"
retryMax := "5m"
replicaImage := "dellemc/dell-replication-controller:v1.3.0"
replicaImage := "dellemc/dell-replication-controller:v1.3.1"

for _, component := range replica.Components {
if component.Name == utils.ReplicationControllerManager {
Expand Down
2 changes: 1 addition & 1 deletion samples/storage_csm_powerscale_v250.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ spec:
- name: dell-replication-controller-manager
# image: Defines controller image. This shouldn't be changed
# Allowed values: string
image: dellemc/dell-replication-controller:v1.3.0
image: dellemc/dell-replication-controller:v1.3.1
envs:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhi16394 , any reason behind not bumping up the config version of replication module

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rensyct could you give more details on this for our understanding? Where is the config version?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line No 261 in the same file

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe no new config version was added, since there were nothing in there that needed change (although for consistency it would have been nice). https://github.com/dell/csm-operator/tree/main/operatorconfig/moduleconfig/replication has 1.3.0 as the latest version. I am guessing this is the reason for keeping config version as 1.3.0, but I will let @abhi16394 clarify.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add new folder for replication under https://github.com/dell/csm-operator/tree/main/operatorconfig/moduleconfig/replication if config version was bumped else validation in code fails

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the replication team is not releasing the entire module
they are bumping up just the replication-controller image
Also there are no changes in replication module folder as the image is in the go file under replication.go

# TARGET_CLUSTERS_IDS: comma separated list of clusters id of the targets clusters. DO NOT include the source(wherever CSM Operator is deployed) cluster id
# Allowed values: string
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/testfiles/storage_csm_powerscale.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ spec:
- name: dell-replication-controller-manager
# image: Defines controller image. This shouldn't be changed
# Allowed values: string
image: dellemc/dell-replication-controller:v1.3.0
image: dellemc/dell-replication-controller:v1.3.1
envs:
# TARGET_CLUSTERS_IDS: comma separated list of clusters id of the targets clusters. DO NOT include the source(wherever CSM Operator is deployed) cluster id
# Allowed values: string
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/testfiles/storage_csm_powerscale_replica.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ spec:
- name: dell-replication-controller-manager
# image: Defines controller image. This shouldn't be changed
# Allowed values: string
image: dellemc/dell-replication-controller:v1.3.0
image: dellemc/dell-replication-controller:v1.3.1
envs:
# TARGET_CLUSTERS_IDS: comma separated list of clusters id of the targets clusters. DO NOT include the source(wherever CSM Operator is deployed) cluster id
# Allowed values: string
Expand Down