Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update rep-controller image #147

Merged
merged 1 commit into from
Dec 1, 2022
Merged

update rep-controller image #147

merged 1 commit into from
Dec 1, 2022

Conversation

abhi16394
Copy link
Collaborator

@abhi16394 abhi16394 commented Dec 1, 2022 •
edited by bharathsreekanth
Loading

Description

bumping replication-controller image for csi-powerscale- v2.5.0

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#491

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@abhi16394 abhi16394 merged commit ab81863 into main Dec 1, 2022
@abhi16394 abhi16394 deleted the update-replication branch December 1, 2022 18:21
rensyct
rensyct reviewed Dec 2, 2022
View reviewed changes
samples/storage_csm_powerscale_v250.yaml
@@ -280,7 +280,7 @@ spec:
- name: dell-replication-controller-manager
# image: Defines controller image. This shouldn't be changed
# Allowed values: string
image: dellemc/dell-replication-controller:v1.3.0
image: dellemc/dell-replication-controller:v1.3.1
envs:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhi16394 , any reason behind not bumping up the config version of replication module

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rensyct could you give more details on this for our understanding? Where is the config version?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line No 261 in the same file

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe no new config version was added, since there were nothing in there that needed change (although for consistency it would have been nice). https://github.com/dell/csm-operator/tree/main/operatorconfig/moduleconfig/replication has 1.3.0 as the latest version. I am guessing this is the reason for keeping config version as 1.3.0, but I will let @abhi16394 clarify.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add new folder for replication under https://github.com/dell/csm-operator/tree/main/operatorconfig/moduleconfig/replication if config version was bumped else validation in code fails

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the replication team is not releasing the entire module
they are bumping up just the replication-controller image
Also there are no changes in replication module folder as the image is in the go file under replication.go

ChristianAtDell added a commit that referenced this pull request Oct 15, 2024
@ChristianAtDell
update rep-controller image (#147)
a15443f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathsreekanth bharathsreekanth bharathsreekanth approved these changes

@rensyct rensyct rensyct left review comments

@kumarkgosa kumarkgosa kumarkgosa approved these changes

@harshaatdell harshaatdell harshaatdell approved these changes

@mbasha-dell mbasha-dell Awaiting requested review from mbasha-dell mbasha-dell is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@JacobGros JacobGros Awaiting requested review from JacobGros JacobGros is a code owner

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna jooseppi-luna is a code owner

@karthikk92 karthikk92 Awaiting requested review from karthikk92 karthikk92 is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@abhi16394 @harshaatdell @rensyct @bharathsreekanth @kumarkgosa